anti/DECNET
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(ui): forwards_l3 toggle in Inspector with destructive-recreate confirm

Browse Source 
W5's apply_update_decky now accepts a forwards_l3 flip on a live
topology only when payload['force'] is true (the unforced flip raises
MutationError to keep half-thinking operators from killing
in-container state).  Until this commit there was no UI surface that
could even submit such a flip.

Inspector grows a 'PROMOTE TO GATEWAY' / 'DEMOTE GATEWAY' button when
a (non-observed) decky is selected.  The handler:

* On pending topologies → submits via editor.updateDecky immediately.
  No confirm dialog; no live containers to disturb.
* On active/degraded topologies → window.confirm() explaining the
  destructive base recreate ('In-container state is lost; active
  sessions to it drop'), then submits with extras.force=true.

useTopologyEditor.updateDecky grows an optional extras arg that
threads force: true into the queued mutation payload.  The pending
CRUD path ignores it (no force needed when no containers exist).

MazeNET.tsx wires a toggleGateway callback that handles the
optimistic local state update, surfaces an enqueue toast on the
active path, and lets the SSE forwarder reconcile when
mutation.applied lands.
This commit is contained in:
anti
2026-04-29 00:29:46 -04:00
parent a27e3f5e0f
commit c002c5a4f1
3 changed files with 92 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

50
decnet_web/src/components/MazeNET/Inspector.tsx
View File

@@ -34,6 +34,11 @@ interface Props {
onLiveRemoveService?: (nodeName: string, slug: string) => Promise<void>;
/** Per-decky-eligible service slugs, fetched via useServiceRegistry. */
availableServices?: string[];
/** Toggle ``forwards_l3`` (gateway) on the selected decky. When the
* topology is active/degraded the caller is responsible for the
* destructive-recreate confirm dialog and the ``force: true`` submit
* — this prop just relays the user's intent. */
onToggleGateway?: (nodeId: string, nextValue: boolean) => Promise<void>;
onAddDecky?: (netId: string) => void;
setSelection?: (sel: Selection) => void;
pendingChanges?: number;
@@ -44,6 +49,7 @@ const Inspector: React.FC<Props> = ({
selection, nets, nodes, edges, topologyStatus, onClose,
onDeleteNet, onDeleteNode, onDeleteEdge, onRemoveService,
onLiveAddService, onLiveRemoveService, availableServices = [],
onToggleGateway,
onAddDecky, setSelection,
pendingChanges = 0,
className = '',
@@ -257,6 +263,50 @@ const Inspector: React.FC<Props> = ({
<div className="dim inspector-empty-line">NO EDGES</div>
)}
</div>
{onToggleGateway && !isObserved && (
<button
type="button"
className={`maze-btn small ${isGateway ? 'alert' : ''}`}
disabled={busy === '__gateway__'}
title={
isGateway
? 'Demote this decky from gateway (forwards_l3=false)'
: 'Promote this decky to gateway (forwards_l3=true)'
}
onClick={async () => {
const next = !isGateway;
// forwards_l3 flip on a deployed topology recreates
// the base container — destructive. Confirm before
// hitting the API; the caller (MazeNET.tsx) submits
// with force: true on active topologies.
const live = topologyStatus === 'active' || topologyStatus === 'degraded';
if (live) {
const ok = window.confirm(
`${next ? 'Promote' : 'Demote'} ${node.name} ${next ? 'to' : 'from'} gateway?\n\n` +
'This recreates the base container to apply the new port-publishing config. ' +
'In-container state is lost; active sessions to it drop.',
);
if (!ok) return;
}
setOpError(null);
setBusy('__gateway__');
try {
await onToggleGateway(node.id, next);
} catch (err) {
const msg = (err as { response?: { data?: { detail?: string } } })?.response?.data?.detail
?? 'Gateway toggle failed.';
setOpError(msg);
} finally {
setBusy(null);
}
}}
>
<Shield size={12} />
{busy === '__gateway__'
? (isGateway ? 'DEMOTING…' : 'PROMOTING…')
: (isGateway ? 'DEMOTE GATEWAY' : 'PROMOTE TO GATEWAY')}
</button>
)}
{onDeleteNode && (
<button
type="button"