anti
df84981954
Every mutation route that returned an untyped dict now declares
response_model at the decorator. MessageResponse covers the eight
{"message": ...} envelopes (change-password, mutate-decky, mutate-
interval, update-deployment-limit, update-global-mutation-interval,
delete-user, update-user-role, reset-user-password). Purpose-built
models cover the richer shapes (DeployResponse for /deckies/deploy,
PurgeResponse for /config/reinit, ReapReportResponse for /reap-orphans,
UserResponse for /config/users). 204-No-Content and Response/
ORJSONResponse routes stay as-is.
The wire shape for clients is unchanged — the envelopes already only
shipped a message field. What changes is that a handler which
accidentally returns a richer dict (e.g. a full user row including
password_hash) would be silently stripped to the declared fields at
serialization time.
Also flips F4/D "expensive LIKE" to accepted (new DA-09) — the /logs
and /attackers search routes LIKE-scan unbounded columns, but both are
admin-gated, limit-capped, and operator rate-limit scope per DA-04.
FTS5 stays a performance TODO, not a security blocker.
46 lines
1.8 KiB
Python
46 lines
1.8 KiB
Python
from fastapi import APIRouter, Depends, HTTPException
|
|
|
|
from decnet.telemetry import traced as _traced
|
|
from decnet.config import DecnetConfig
|
|
from decnet.web.dependencies import require_admin, repo
|
|
from decnet.web.db.models import MessageResponse, MutateIntervalRequest
|
|
|
|
router = APIRouter()
|
|
|
|
_UNIT_TO_MINUTES = {"m": 1, "d": 1440, "M": 43200, "y": 525600, "Y": 525600}
|
|
|
|
|
|
def _parse_duration(s: str) -> int:
|
|
"""Convert a duration string (e.g. '5d') to minutes."""
|
|
value, unit = int(s[:-1]), s[-1]
|
|
return value * _UNIT_TO_MINUTES[unit]
|
|
|
|
|
|
@router.put("/deckies/{decky_name}/mutate-interval", tags=["Fleet Management"],
|
|
response_model=MessageResponse,
|
|
responses={
|
|
400: {"description": "Bad Request (e.g. malformed JSON)"},
|
|
401: {"description": "Could not validate credentials"},
|
|
403: {"description": "Insufficient permissions"},
|
|
404: {"description": "No active deployment or decky not found"},
|
|
422: {"description": "Validation error"}
|
|
},
|
|
)
|
|
@_traced("api.update_mutate_interval")
|
|
async def api_update_mutate_interval(decky_name: str, req: MutateIntervalRequest, admin: dict = Depends(require_admin)) -> dict[str, str]:
|
|
state_dict = await repo.get_state("deployment")
|
|
if not state_dict:
|
|
raise HTTPException(status_code=404, detail="No active deployment")
|
|
|
|
config = DecnetConfig(**state_dict["config"])
|
|
compose_path = state_dict["compose_path"]
|
|
|
|
decky = next((d for d in config.deckies if d.name == decky_name), None)
|
|
if not decky:
|
|
raise HTTPException(status_code=404, detail="Decky not found")
|
|
|
|
decky.mutate_interval = _parse_duration(req.mutate_interval) if req.mutate_interval else None
|
|
|
|
await repo.set_state("deployment", {"config": config.model_dump(), "compose_path": compose_path})
|
|
return {"message": "Mutation interval updated"}
|