anti
df84981954
Every mutation route that returned an untyped dict now declares
response_model at the decorator. MessageResponse covers the eight
{"message": ...} envelopes (change-password, mutate-decky, mutate-
interval, update-deployment-limit, update-global-mutation-interval,
delete-user, update-user-role, reset-user-password). Purpose-built
models cover the richer shapes (DeployResponse for /deckies/deploy,
PurgeResponse for /config/reinit, ReapReportResponse for /reap-orphans,
UserResponse for /config/users). 204-No-Content and Response/
ORJSONResponse routes stay as-is.
The wire shape for clients is unchanged — the envelopes already only
shipped a message field. What changes is that a handler which
accidentally returns a richer dict (e.g. a full user row including
password_hash) would be silently stripped to the declared fields at
serialization time.
Also flips F4/D "expensive LIKE" to accepted (new DA-09) — the /logs
and /attackers search routes LIKE-scan unbounded columns, but both are
admin-gated, limit-capped, and operator rate-limit scope per DA-04.
FTS5 stays a performance TODO, not a security blocker.
35 lines
1.2 KiB
Python
35 lines
1.2 KiB
Python
import os
|
|
from fastapi import APIRouter, Depends, HTTPException, Path
|
|
|
|
from decnet.telemetry import traced as _traced
|
|
from decnet.mutator import mutate_decky
|
|
from decnet.web.db.models import MessageResponse
|
|
from decnet.web.dependencies import require_admin, repo
|
|
|
|
router = APIRouter()
|
|
|
|
|
|
@router.post(
|
|
"/deckies/{decky_name}/mutate",
|
|
tags=["Fleet Management"],
|
|
response_model=MessageResponse,
|
|
responses={
|
|
401: {"description": "Could not validate credentials"},
|
|
403: {"description": "Insufficient permissions"},
|
|
404: {"description": "Decky not found"},
|
|
422: {"description": "Path parameter validation error (decky_name must match ^[a-z0-9\\-]{1,64}$)"},
|
|
}
|
|
)
|
|
@_traced("api.mutate_decky")
|
|
async def api_mutate_decky(
|
|
decky_name: str = Path(..., pattern=r"^[a-z0-9\-]{1,64}$"),
|
|
admin: dict = Depends(require_admin),
|
|
) -> dict[str, str]:
|
|
if os.environ.get("DECNET_CONTRACT_TEST") == "true":
|
|
return {"message": f"Successfully mutated {decky_name} (Contract Test Mock)"}
|
|
|
|
success = await mutate_decky(decky_name, repo=repo)
|
|
if success:
|
|
return {"message": f"Successfully mutated {decky_name}"}
|
|
raise HTTPException(status_code=404, detail=f"Decky {decky_name} not found or failed to mutate")
|