Closes the cred-coverage gap for 7 services that already had the data
on the wire but never landed it in the Credential table:
- SNMP — community string lands as secret_kind="snmp_community",
principal=None (v1/v2c has no per-user identity, the community IS
the auth).
- SIP — Digest response hash, previously buried in the auth= header
dump, now classify_authorization()-extracted.
- HTTP / HTTPS — Authorization header was in the headers JSON but
never extracted. Now Basic decodes to plaintext, Bearer →
http_bearer (principal=None), Digest → http_digest_md5.
- K8s — already extracted Authorization but didn't normalize. Service-
account JWTs flow through as Bearer.
- Docker API — headers absent entirely. Adds the headers JSON dump
and runs Authorization through the classifier.
- Elasticsearch — five distinct request handlers; each gains a
per-handler _cred_fields() helper.
Adds canonical templates/syslog_bridge.py:classify_authorization().
Recognised: Basic / Bearer / Token / Digest. Unknown schemes (NTLM,
AWS4-HMAC, Negotiate) return None; the header still rides in the
ambient SD-block but isn't normalized as a credential. The SD shape
on the wire collapses sip_digest_md5 into http_digest_md5 — same
algorithm, so cross-protocol reuse correlates correctly when (rare)
nonce collisions allow.
Drive-by repair of tests/core/test_fingerprinting.py:
- The pre-existing `test_http_useragent_extracted` asserted both that
add_bounty was called exactly once AND that the UA payload carried
`path` and `method` fields. Both wrong since this session opened:
the http_quirks fingerprint added later fires too, and the UA
payload never actually included path/method despite the assertion.
- Adds `path`/`method` to the UA fingerprint payload (real operator
value: "Nikto hit /admin" beats "Nikto seen on this decky").
- Replaces `assert_awaited_once` with a `_find_ua_bounty()` helper
that filters add_bounty calls by `fingerprint_type`. New fingerprint
families landing later won't retroactively break old tests.
- Updates the two credential-bearing tests to use the post-DEBT-039
native shape (`secret_b64` / `principal`) and `upsert_credential`,
not the deleted legacy `username+password` adapter.
Also rebuilds the per-service fake `syslog_bridge` modules in
tests/service_testing/{conftest,test_imap,test_pop3,test_snmp,test_mqtt,test_smtp}.py
to expose `encode_secret` + `classify_authorization`. Service templates
that import either now no longer fail at test collection.
173 tests pass in the touched scope. Phases 2-7 still pending.
149 lines
4.2 KiB
Python
149 lines
4.2 KiB
Python
#!/usr/bin/env python3
|
|
"""
|
|
SIP server (UDP + TCP port 5060).
|
|
Parses SIP REGISTER and INVITE messages, logs credentials from the
|
|
Authorization header and call metadata, then responds with 401 Unauthorized.
|
|
"""
|
|
|
|
import asyncio
|
|
import os
|
|
import re
|
|
from syslog_bridge import (
|
|
classify_authorization,
|
|
forward_syslog,
|
|
syslog_line,
|
|
write_syslog_file,
|
|
)
|
|
|
|
NODE_NAME = os.environ.get("NODE_NAME", "pbx")
|
|
SERVICE_NAME = "sip"
|
|
LOG_TARGET = os.environ.get("LOG_TARGET", "")
|
|
|
|
_401 = (
|
|
"SIP/2.0 401 Unauthorized\r\n"
|
|
"Via: {via}\r\n"
|
|
"From: {from_}\r\n"
|
|
"To: {to}\r\n"
|
|
"Call-ID: {call_id}\r\n"
|
|
"CSeq: {cseq}\r\n"
|
|
'WWW-Authenticate: Digest realm="{host}", nonce="{nonce}", algorithm=MD5\r\n'
|
|
"Content-Length: 0\r\n\r\n"
|
|
)
|
|
|
|
|
|
|
|
|
|
def _log(event_type: str, severity: int = 6, **kwargs) -> None:
|
|
line = syslog_line(SERVICE_NAME, NODE_NAME, event_type, severity, **kwargs)
|
|
write_syslog_file(line)
|
|
forward_syslog(line, LOG_TARGET)
|
|
|
|
|
|
def _parse_headers(msg: str) -> dict:
|
|
headers = {}
|
|
for line in msg.splitlines()[1:]:
|
|
if ":" in line:
|
|
k, _, v = line.partition(":")
|
|
headers[k.strip().lower()] = v.strip()
|
|
return headers
|
|
|
|
|
|
def _handle_message(data: bytes, src_addr) -> bytes | None:
|
|
try:
|
|
msg = data.decode(errors="replace")
|
|
except Exception:
|
|
return None
|
|
first_line = msg.splitlines()[0] if msg else ""
|
|
method = first_line.split()[0] if first_line else "UNKNOWN"
|
|
headers = _parse_headers(msg)
|
|
|
|
auth_header = headers.get("authorization", "")
|
|
username = ""
|
|
if auth_header:
|
|
m = re.search(r'username="([^"]+)"', auth_header)
|
|
username = m.group(1) if m else ""
|
|
|
|
# SIP Digest is the same shape as HTTP Digest (RFC 7616 derived from
|
|
# RFC 2617). classify_authorization handles it identically — emits
|
|
# secret_kind="http_digest_md5", which is correct: the cred is the
|
|
# MD5 hash response, regardless of whether it rode in over SIP or
|
|
# HTTP. Reuse-analytics correlates across both.
|
|
cred = classify_authorization(auth_header)
|
|
|
|
_log(
|
|
"request",
|
|
src=src_addr[0],
|
|
src_port=src_addr[1],
|
|
method=method,
|
|
from_=headers.get("from", ""),
|
|
to=headers.get("to", ""),
|
|
username=username,
|
|
auth=auth_header[:256],
|
|
**(cred or {}),
|
|
)
|
|
|
|
if method in ("REGISTER", "INVITE", "OPTIONS"):
|
|
nonce = os.urandom(8).hex()
|
|
response = _401.format(
|
|
via=headers.get("via", ""),
|
|
from_=headers.get("from", ""),
|
|
to=headers.get("to", ""),
|
|
call_id=headers.get("call-id", ""),
|
|
cseq=headers.get("cseq", ""),
|
|
host=NODE_NAME,
|
|
nonce=nonce,
|
|
)
|
|
return response.encode()
|
|
return None
|
|
|
|
|
|
class SIPUDPProtocol(asyncio.DatagramProtocol):
|
|
def __init__(self):
|
|
self._transport = None
|
|
|
|
def connection_made(self, transport):
|
|
self._transport = transport
|
|
|
|
def datagram_received(self, data, addr):
|
|
response = _handle_message(data, addr)
|
|
if response and self._transport:
|
|
self._transport.sendto(response, addr)
|
|
|
|
|
|
class SIPTCPProtocol(asyncio.Protocol):
|
|
def __init__(self):
|
|
self._transport = None
|
|
self._peer = None
|
|
self._buf = b""
|
|
|
|
def connection_made(self, transport):
|
|
self._transport = transport
|
|
self._peer = transport.get_extra_info("peername", ("?", 0))
|
|
|
|
def data_received(self, data):
|
|
self._buf += data
|
|
if b"\r\n\r\n" in self._buf or b"\n\n" in self._buf:
|
|
response = _handle_message(self._buf, self._peer)
|
|
self._buf = b""
|
|
if response:
|
|
self._transport.write(response)
|
|
|
|
def connection_lost(self, exc):
|
|
pass
|
|
|
|
|
|
async def main():
|
|
_log("startup", msg=f"SIP server starting as {NODE_NAME}")
|
|
loop = asyncio.get_running_loop()
|
|
udp_transport, _ = await loop.create_datagram_endpoint(
|
|
SIPUDPProtocol, local_addr=("0.0.0.0", 5060) # nosec B104
|
|
)
|
|
tcp_server = await loop.create_server(SIPTCPProtocol, "0.0.0.0", 5060) # nosec B104
|
|
async with tcp_server:
|
|
await tcp_server.serve_forever()
|
|
udp_transport.close()
|
|
|
|
|
|
if __name__ == "__main__":
|
|
asyncio.run(main())
|