Files
DECNET/tests/intel/test_greynoise.py
anti 999d3494b4 feat(intel): persist per-provider taxonomy on AttackerIntel for TTP dispatch
The 2026-05-02 ship-time audit of the R0054-R0058 intel rule pack found
that AbuseIPDB / GreyNoise / ThreatFox stored only the aggregate verdict
(score / classification / listed-bool) plus the raw response blob. The
TTP IntelLifter expects per-provider taxonomy fields (categories, tags,
threat_types) that were never populated, so R0054 / R0055 / R0057
emitted zero tags in production despite passing unit tests.

Add typed columns: abuseipdb_categories, greynoise_tags, greynoise_name,
feodo_malware_family, threatfox_threat_types, threatfox_ioc_types,
threatfox_malware_families. Each provider now parses the relevant
taxonomy out of the upstream response and writes it through
column_updates. JSON-list columns ride as TEXT with default "[]" to
keep the SQLite/MySQL backend split honest, deserialised back to native
lists by the repo on read.
2026-05-02 18:07:57 -04:00

176 lines
5.7 KiB
Python

"""Unit tests for the GreyNoise Community provider.
Mocks httpx via ``MockTransport`` and asserts:
* request URL + headers (API key when present, none when absent)
* malicious / benign / suspicious classification → verdict mapping
* 404 → verdict='unknown' with no error (cache the absence)
* non-200/404 → error populated, no column writes
* network exception → error populated
* the row never advertises DECNET in the egress UA
"""
from __future__ import annotations
import json
import httpx
import pytest
from decnet.intel.greynoise import GreyNoiseProvider
def _install_transport(provider: GreyNoiseProvider, handler) -> list[httpx.Request]:
"""Patch ``stealth_client`` so it returns a client wired to ``handler``."""
captured: list[httpx.Request] = []
async def _wrapped(request: httpx.Request) -> httpx.Response:
captured.append(request)
return await handler(request)
transport = httpx.MockTransport(_wrapped)
from decnet.intel import greynoise as gn_mod
def _factory():
return httpx.AsyncClient(
transport=transport,
headers={"User-Agent": "curl/7.88.1"},
)
gn_mod.stealth_client = _factory # type: ignore[assignment]
return captured
@pytest.mark.anyio
async def test_malicious_classification_maps_to_verdict():
async def handler(request: httpx.Request) -> httpx.Response:
return httpx.Response(
200,
json={
"ip": "1.2.3.4",
"noise": True,
"classification": "malicious",
"name": "Mirai-like",
},
)
provider = GreyNoiseProvider()
captured = _install_transport(provider, handler)
result = await provider.lookup("1.2.3.4")
assert result.error is None
assert result.verdict == "malicious"
assert result.column_updates["greynoise_classification"] == "malicious"
raw = json.loads(result.column_updates["greynoise_raw"])
assert raw["name"] == "Mirai-like"
assert "1.2.3.4" in str(captured[0].url)
# No DECNET label leaks in the UA.
assert "decnet" not in captured[0].headers["user-agent"].lower()
@pytest.mark.anyio
async def test_api_key_is_sent_when_configured(monkeypatch):
monkeypatch.setenv("DECNET_GREYNOISE_API_KEY", "k3y-abc")
async def handler(request: httpx.Request) -> httpx.Response:
return httpx.Response(200, json={"classification": "benign"})
provider = GreyNoiseProvider()
captured = _install_transport(provider, handler)
await provider.lookup("8.8.8.8")
assert captured[0].headers.get("key") == "k3y-abc"
@pytest.mark.anyio
async def test_no_api_key_means_no_header(monkeypatch):
monkeypatch.delenv("DECNET_GREYNOISE_API_KEY", raising=False)
async def handler(request: httpx.Request) -> httpx.Response:
return httpx.Response(200, json={"classification": "benign"})
provider = GreyNoiseProvider()
captured = _install_transport(provider, handler)
await provider.lookup("8.8.8.8")
assert "key" not in captured[0].headers
@pytest.mark.anyio
async def test_404_caches_unknown_without_error():
async def handler(request: httpx.Request) -> httpx.Response:
return httpx.Response(404, json={"message": "IP not observed"})
provider = GreyNoiseProvider()
_install_transport(provider, handler)
result = await provider.lookup("10.0.0.5")
assert result.error is None
assert result.verdict == "unknown"
assert result.column_updates["greynoise_classification"] == "unknown"
@pytest.mark.anyio
async def test_429_returns_error_no_writes():
async def handler(request: httpx.Request) -> httpx.Response:
return httpx.Response(429)
provider = GreyNoiseProvider()
_install_transport(provider, handler)
result = await provider.lookup("1.1.1.1")
assert result.error == "HTTP 429"
assert result.column_updates == {}
@pytest.mark.anyio
async def test_actor_name_and_tags_persisted_when_present():
"""Post-2026-05-02 audit: ``name`` (actor label) and any ``tags``
list returned by the upstream survive into ``column_updates``.
The Community endpoint does not return ``tags`` in practice; the
test seeds the field anyway so non-Community provider plans that
do (paid / Enterprise) work without further code changes.
"""
async def handler(request: httpx.Request) -> httpx.Response:
return httpx.Response(
200,
json={
"classification": "malicious",
"name": "Tor",
"tags": ["tor_exit_node", "ssh_bruteforcer"],
},
)
provider = GreyNoiseProvider()
_install_transport(provider, handler)
result = await provider.lookup("1.2.3.4")
assert result.column_updates["greynoise_name"] == "Tor"
tags = json.loads(result.column_updates["greynoise_tags"])
assert tags == ["tor_exit_node", "ssh_bruteforcer"]
@pytest.mark.anyio
async def test_404_clears_actor_and_tags():
async def handler(request: httpx.Request) -> httpx.Response:
return httpx.Response(404, json={"message": "not seen"})
provider = GreyNoiseProvider()
_install_transport(provider, handler)
result = await provider.lookup("10.0.0.5")
assert result.column_updates["greynoise_name"] is None
assert result.column_updates["greynoise_tags"] == "[]"
@pytest.mark.anyio
async def test_network_failure_becomes_error():
async def handler(request: httpx.Request) -> httpx.Response:
raise httpx.ConnectError("upstream unreachable")
provider = GreyNoiseProvider()
_install_transport(provider, handler)
result = await provider.lookup("1.1.1.1")
assert result.error and result.error.startswith("network:")
assert result.column_updates == {}