anti
ae92948e22
Three unrelated test-correctness fixes exposed by running tests/live: - test_mqtt_live: honeypot defaults to auth-required (post-2018 realistic broker). Anonymous CONNECT is rejected with CONNACK rc=5, which the "accept" / "subscribe" tests misread as a failure. Pass MQTT_ACCEPT_ALL=1 via a new env= override on the live_service factory so only those two tests opt into accept-all. - test_postgres_live::test_auth_hash_logged: connected with dbname='prod', which isn't in the honeypot's per-instance DB list, so Postgres (correctly) rejected at startup before asking for a password — blowing past the auth event the test asserts on. Target 'postgres' (always in _BASE_DBS) to reach the auth stage. - test_mysql_backend_live: the module-scoped mysql_test_db_url fixture is bound to the module loop, but function-scoped tests default to their own per-function loops. Any reuse of the asyncmy pool then tripped "Future attached to a different loop". Pin the whole module with pytest.mark.asyncio(loop_scope='module').
70 lines
2.6 KiB
Python
70 lines
2.6 KiB
Python
import time
|
|
|
|
import pytest
|
|
import paho.mqtt.client as mqtt
|
|
|
|
from tests.live.conftest import assert_rfc5424
|
|
|
|
|
|
@pytest.mark.live
|
|
class TestMQTTLive:
|
|
def test_connect_accepted(self, live_service):
|
|
# The honeypot defaults to auth-required (post-2018 realistic
|
|
# broker posture). Opt into accept-all mode to exercise the
|
|
# happy-path CONNACK rc=0 code path. See decnet/templates/mqtt/
|
|
# server.py::MQTT_ACCEPT_ALL.
|
|
port, drain = live_service("mqtt", env={"MQTT_ACCEPT_ALL": "1"})
|
|
connected = []
|
|
client = mqtt.Client(client_id="test-scanner")
|
|
client.on_connect = lambda c, u, f, rc: connected.append(rc)
|
|
client.connect("127.0.0.1", port, keepalive=5)
|
|
client.loop_start()
|
|
deadline = time.monotonic() + 5
|
|
while not connected and time.monotonic() < deadline:
|
|
time.sleep(0.05)
|
|
client.loop_stop()
|
|
client.disconnect()
|
|
assert connected and connected[0] == 0, f"Expected CONNACK rc=0, got {connected}"
|
|
|
|
def test_connect_logged(self, live_service):
|
|
port, drain = live_service("mqtt")
|
|
client = mqtt.Client(client_id="hax0r")
|
|
client.connect("127.0.0.1", port, keepalive=5)
|
|
client.loop_start()
|
|
time.sleep(0.3)
|
|
client.loop_stop()
|
|
client.disconnect()
|
|
lines = drain()
|
|
assert_rfc5424(lines, service="mqtt", event_type="auth")
|
|
|
|
def test_client_id_in_log(self, live_service):
|
|
port, drain = live_service("mqtt")
|
|
client = mqtt.Client(client_id="evil-scanner-9000")
|
|
client.connect("127.0.0.1", port, keepalive=5)
|
|
client.loop_start()
|
|
time.sleep(0.3)
|
|
client.loop_stop()
|
|
client.disconnect()
|
|
lines = drain()
|
|
matched = assert_rfc5424(lines, service="mqtt", event_type="auth")
|
|
assert "evil-scanner-9000" in matched, (
|
|
f"Expected client_id in log line. Got:\n{matched!r}"
|
|
)
|
|
|
|
def test_subscribe_logged(self, live_service):
|
|
# SUBSCRIBE is gated on successful auth — accept-all lets the test
|
|
# reach the subscribe path without planting credentials.
|
|
port, drain = live_service("mqtt", env={"MQTT_ACCEPT_ALL": "1"})
|
|
subscribed = []
|
|
client = mqtt.Client(client_id="sub-test")
|
|
client.on_subscribe = lambda c, u, mid, qos: subscribed.append(mid)
|
|
client.connect("127.0.0.1", port, keepalive=5)
|
|
client.loop_start()
|
|
time.sleep(0.2)
|
|
client.subscribe("plant/#")
|
|
time.sleep(0.3)
|
|
client.loop_stop()
|
|
client.disconnect()
|
|
lines = drain()
|
|
assert_rfc5424(lines, service="mqtt", event_type="subscribe")
|