anti
df84981954
Every mutation route that returned an untyped dict now declares
response_model at the decorator. MessageResponse covers the eight
{"message": ...} envelopes (change-password, mutate-decky, mutate-
interval, update-deployment-limit, update-global-mutation-interval,
delete-user, update-user-role, reset-user-password). Purpose-built
models cover the richer shapes (DeployResponse for /deckies/deploy,
PurgeResponse for /config/reinit, ReapReportResponse for /reap-orphans,
UserResponse for /config/users). 204-No-Content and Response/
ORJSONResponse routes stay as-is.
The wire shape for clients is unchanged — the envelopes already only
shipped a message field. What changes is that a handler which
accidentally returns a richer dict (e.g. a full user row including
password_hash) would be silently stripped to the declared fields at
serialization time.
Also flips F4/D "expensive LIKE" to accepted (new DA-09) — the /logs
and /attackers search routes LIKE-scan unbounded columns, but both are
admin-gated, limit-capped, and operator rate-limit scope per DA-04.
FTS5 stays a performance TODO, not a security blocker.
145 lines
4.5 KiB
Python
145 lines
4.5 KiB
Python
import uuid as _uuid
|
|
|
|
from fastapi import APIRouter, Depends, HTTPException
|
|
|
|
from decnet.telemetry import traced as _traced
|
|
from decnet.web.auth import ahash_password
|
|
from decnet.web.dependencies import require_admin, invalidate_user_cache, repo
|
|
from decnet.web.router.config.api_get_config import invalidate_list_users_cache
|
|
from decnet.web.db.models import (
|
|
CreateUserRequest,
|
|
MessageResponse,
|
|
ResetUserPasswordRequest,
|
|
UpdateUserRoleRequest,
|
|
UserResponse,
|
|
)
|
|
|
|
router = APIRouter()
|
|
|
|
|
|
@router.post(
|
|
"/config/users",
|
|
tags=["Configuration"],
|
|
response_model=UserResponse,
|
|
responses={
|
|
400: {"description": "Bad Request (e.g. malformed JSON)"},
|
|
401: {"description": "Could not validate credentials"},
|
|
403: {"description": "Admin access required"},
|
|
409: {"description": "Username already exists"},
|
|
422: {"description": "Validation error"},
|
|
},
|
|
)
|
|
@_traced("api.create_user")
|
|
async def api_create_user(
|
|
req: CreateUserRequest,
|
|
admin: dict = Depends(require_admin),
|
|
) -> UserResponse:
|
|
existing = await repo.get_user_by_username(req.username)
|
|
if existing:
|
|
raise HTTPException(status_code=409, detail="Username already exists")
|
|
|
|
user_uuid = str(_uuid.uuid4())
|
|
await repo.create_user({
|
|
"uuid": user_uuid,
|
|
"username": req.username,
|
|
"password_hash": await ahash_password(req.password),
|
|
"role": req.role,
|
|
"must_change_password": True, # nosec B105 — not a password
|
|
})
|
|
invalidate_list_users_cache()
|
|
return UserResponse(
|
|
uuid=user_uuid,
|
|
username=req.username,
|
|
role=req.role,
|
|
must_change_password=True,
|
|
)
|
|
|
|
|
|
@router.delete(
|
|
"/config/users/{user_uuid}",
|
|
tags=["Configuration"],
|
|
response_model=MessageResponse,
|
|
responses={
|
|
401: {"description": "Could not validate credentials"},
|
|
403: {"description": "Admin access required / cannot delete self"},
|
|
404: {"description": "User not found"},
|
|
},
|
|
)
|
|
@_traced("api.delete_user")
|
|
async def api_delete_user(
|
|
user_uuid: str,
|
|
admin: dict = Depends(require_admin),
|
|
) -> dict[str, str]:
|
|
if user_uuid == admin["uuid"]:
|
|
raise HTTPException(status_code=403, detail="Cannot delete your own account")
|
|
|
|
deleted = await repo.delete_user(user_uuid)
|
|
if not deleted:
|
|
raise HTTPException(status_code=404, detail="User not found")
|
|
invalidate_user_cache(user_uuid)
|
|
invalidate_list_users_cache()
|
|
return {"message": "User deleted"}
|
|
|
|
|
|
@router.put(
|
|
"/config/users/{user_uuid}/role",
|
|
tags=["Configuration"],
|
|
response_model=MessageResponse,
|
|
responses={
|
|
400: {"description": "Bad Request (e.g. malformed JSON)"},
|
|
401: {"description": "Could not validate credentials"},
|
|
403: {"description": "Admin access required / cannot change own role"},
|
|
404: {"description": "User not found"},
|
|
422: {"description": "Validation error"},
|
|
},
|
|
)
|
|
@_traced("api.update_user_role")
|
|
async def api_update_user_role(
|
|
user_uuid: str,
|
|
req: UpdateUserRoleRequest,
|
|
admin: dict = Depends(require_admin),
|
|
) -> dict[str, str]:
|
|
if user_uuid == admin["uuid"]:
|
|
raise HTTPException(status_code=403, detail="Cannot change your own role")
|
|
|
|
target = await repo.get_user_by_uuid(user_uuid)
|
|
if not target:
|
|
raise HTTPException(status_code=404, detail="User not found")
|
|
|
|
await repo.update_user_role(user_uuid, req.role)
|
|
invalidate_user_cache(user_uuid)
|
|
invalidate_list_users_cache()
|
|
return {"message": "User role updated"}
|
|
|
|
|
|
@router.put(
|
|
"/config/users/{user_uuid}/reset-password",
|
|
tags=["Configuration"],
|
|
response_model=MessageResponse,
|
|
responses={
|
|
400: {"description": "Bad Request (e.g. malformed JSON)"},
|
|
401: {"description": "Could not validate credentials"},
|
|
403: {"description": "Admin access required"},
|
|
404: {"description": "User not found"},
|
|
422: {"description": "Validation error"},
|
|
},
|
|
)
|
|
@_traced("api.reset_user_password")
|
|
async def api_reset_user_password(
|
|
user_uuid: str,
|
|
req: ResetUserPasswordRequest,
|
|
admin: dict = Depends(require_admin),
|
|
) -> dict[str, str]:
|
|
target = await repo.get_user_by_uuid(user_uuid)
|
|
if not target:
|
|
raise HTTPException(status_code=404, detail="User not found")
|
|
|
|
await repo.update_user_password(
|
|
user_uuid,
|
|
await ahash_password(req.new_password),
|
|
must_change_password=True,
|
|
)
|
|
invalidate_user_cache(user_uuid)
|
|
invalidate_list_users_cache()
|
|
return {"message": "Password reset successfully"}
|