refactor(topology): introduce TopologyRepository protocol with DTO return types
Replace repo: BaseRepository with a structural TopologyRepository protocol in persistence.py and allocator.py. All read methods now return typed DTOs (TopologySummary, LANRow, DeckyRow, EdgeRow) instead of raw dicts, eliminating silent field-shape regressions across the topology subsystem. TopologySummary gains email_personas and language_default so api_personas.py can continue reading those fields via attribute access. hydrate() converts DTOs to dicts before passing to _backfill_decky_configs, keeping the mutable working-state function dict-based at its boundary. All production callers (router handlers, mutator, CLI, heartbeat) migrated from dict/get access to attribute access. 134 tests pass.
This commit is contained in:
@@ -73,11 +73,11 @@ async def api_create_lan(
|
||||
raise map_repo_exception(exc) from exc
|
||||
|
||||
rows = await repo.list_lans_for_topology(topology_id)
|
||||
row = next((r for r in rows if r["id"] == lan_id), None)
|
||||
row = next((r for r in rows if r.id == lan_id), None)
|
||||
if row is None: # pragma: no cover — would mean insert vanished
|
||||
raise HTTPException(status_code=500, detail="LAN insert vanished")
|
||||
|
||||
return LANRow(**row)
|
||||
return row
|
||||
|
||||
|
||||
@router.patch(
|
||||
@@ -115,10 +115,10 @@ async def api_update_lan(
|
||||
raise HTTPException(status_code=404, detail=str(exc)) from exc
|
||||
|
||||
rows = await repo.list_lans_for_topology(topology_id)
|
||||
row = next((r for r in rows if r["id"] == lan_id), None)
|
||||
row = next((r for r in rows if r.id == lan_id), None)
|
||||
if row is None:
|
||||
raise HTTPException(status_code=404, detail="LAN not found")
|
||||
return LANRow(**row)
|
||||
return row
|
||||
|
||||
|
||||
@router.delete(
|
||||
@@ -142,7 +142,7 @@ async def api_delete_lan(
|
||||
await assert_pending_or_409(topology_id)
|
||||
|
||||
rows = await repo.list_lans_for_topology(topology_id)
|
||||
if not any(r["id"] == lan_id for r in rows):
|
||||
if not any(r.id == lan_id for r in rows):
|
||||
raise HTTPException(status_code=404, detail="LAN not found")
|
||||
|
||||
try:
|
||||
|
||||
Reference in New Issue
Block a user