refactor(topology): introduce TopologyRepository protocol with DTO return types
Replace repo: BaseRepository with a structural TopologyRepository protocol in persistence.py and allocator.py. All read methods now return typed DTOs (TopologySummary, LANRow, DeckyRow, EdgeRow) instead of raw dicts, eliminating silent field-shape regressions across the topology subsystem. TopologySummary gains email_personas and language_default so api_personas.py can continue reading those fields via attribute access. hydrate() converts DTOs to dicts before passing to _backfill_decky_configs, keeping the mutable working-state function dict-based at its boundary. All production callers (router handlers, mutator, CLI, heartbeat) migrated from dict/get access to attribute access. 134 tests pass.
This commit is contained in:
@@ -5,13 +5,13 @@ from ipaddress import IPv4Address, IPv4Network
|
||||
from typing import Any
|
||||
|
||||
from decnet.topology.allocator import IPAllocator
|
||||
from decnet.web.db.repository import BaseRepository
|
||||
from decnet.topology.repository import TopologyRepository
|
||||
from decnet.topology.config import GeneratedTopology
|
||||
from decnet.topology.status import TopologyStatus, assert_transition
|
||||
|
||||
|
||||
async def persist(
|
||||
repo: BaseRepository,
|
||||
repo: TopologyRepository,
|
||||
plan: GeneratedTopology,
|
||||
*,
|
||||
target_host_uuid: str | None = None,
|
||||
@@ -91,7 +91,7 @@ async def persist(
|
||||
|
||||
|
||||
async def transition_status(
|
||||
repo: BaseRepository,
|
||||
repo: TopologyRepository,
|
||||
topology_id: str,
|
||||
new_status: str,
|
||||
reason: str | None = None,
|
||||
@@ -104,11 +104,11 @@ async def transition_status(
|
||||
topo = await repo.get_topology(topology_id)
|
||||
if topo is None:
|
||||
raise ValueError(f"topology {topology_id!r} not found")
|
||||
assert_transition(topo["status"], new_status)
|
||||
assert_transition(topo.status, new_status)
|
||||
await repo.update_topology_status(topology_id, new_status, reason=reason)
|
||||
|
||||
|
||||
async def hydrate(repo: BaseRepository, topology_id: str) -> dict[str, Any] | None:
|
||||
async def hydrate(repo: TopologyRepository, topology_id: str) -> dict[str, Any] | None:
|
||||
"""Load a topology + children into a single dict for callers.
|
||||
|
||||
Shape::
|
||||
@@ -125,15 +125,21 @@ async def hydrate(repo: BaseRepository, topology_id: str) -> dict[str, Any] | No
|
||||
topo = await repo.get_topology(topology_id)
|
||||
if topo is None:
|
||||
return None
|
||||
lans = await repo.list_lans_for_topology(topology_id)
|
||||
deckies = await repo.list_topology_deckies(topology_id)
|
||||
edges = await repo.list_topology_edges(topology_id)
|
||||
_backfill_decky_configs(lans, deckies, edges)
|
||||
lans_dto = await repo.list_lans_for_topology(topology_id)
|
||||
deckies_dto = await repo.list_topology_deckies(topology_id)
|
||||
edges_dto = await repo.list_topology_edges(topology_id)
|
||||
# Convert to dicts for _backfill_decky_configs (mutates decky_config in-place).
|
||||
# mode="json" is mandatory: datetime fields must arrive as ISO strings for all
|
||||
# downstream consumers (canonical_hash, deployer, api_get_topology, etc.).
|
||||
lan_dicts = [m.model_dump(mode="json") for m in lans_dto]
|
||||
decky_dicts = [m.model_dump(mode="json") for m in deckies_dto]
|
||||
edge_dicts = [m.model_dump(mode="json") for m in edges_dto]
|
||||
_backfill_decky_configs(lan_dicts, decky_dicts, edge_dicts)
|
||||
return {
|
||||
"topology": topo,
|
||||
"lans": lans,
|
||||
"deckies": deckies,
|
||||
"edges": edges,
|
||||
"topology": topo.model_dump(mode="json"),
|
||||
"lans": lan_dicts,
|
||||
"deckies": decky_dicts,
|
||||
"edges": edge_dicts,
|
||||
}
|
||||
|
||||
|
||||
|
||||
Reference in New Issue
Block a user