anti/DECNET
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(heartbeat): replace remaining bare except Exception with SQLAlchemyError and typed builtins

Browse Source
This commit is contained in:
anti
2026-04-30 21:08:26 -04:00
parent 542d129d6f
commit f6422f2529
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
decnet/web/router/swarm/api_heartbeat.py
View File

@@ -20,6 +20,7 @@ from typing import Any, Optional
from fastapi import APIRouter, Depends, HTTPException, Request from fastapi import APIRouter, Depends, HTTPException, Request
from pydantic import BaseModel, ValidationError from pydantic import BaseModel, ValidationError
from sqlalchemy.exc import SQLAlchemyError
from decnet.config import DeckyConfig from decnet.config import DeckyConfig
from decnet.logging import get_logger from decnet.logging import get_logger
@@ -122,7 +123,7 @@ async def _reconcile_topology_report(
try: try:
topos = await repo.list_topologies(status=TopologyStatus.ACTIVE) topos = await repo.list_topologies(status=TopologyStatus.ACTIVE)
except Exception: except SQLAlchemyError:
# Non-fatal: reconcile is best-effort; the host stays alive regardless # Non-fatal: reconcile is best-effort; the host stays alive regardless
log.exception("heartbeat: could not list active topologies") log.exception("heartbeat: could not list active topologies")
return return
@@ -141,7 +142,7 @@ async def _reconcile_topology_report(
if reported_id == tid and reported_hash: if reported_id == tid and reported_hash:
try: try:
hydrated = await hydrate(repo, tid) hydrated = await hydrate(repo, tid)
except Exception: except (SQLAlchemyError, KeyError, TypeError):
# Non-fatal: skip this topology; mutator reconcile loop will retry # Non-fatal: skip this topology; mutator reconcile loop will retry
log.exception("heartbeat: hydrate failed tid=%s", tid) log.exception("heartbeat: hydrate failed tid=%s", tid)
continue continue
@@ -158,7 +159,7 @@ async def _reconcile_topology_report(
"reported_id=%s reported_hash=%s expected=%s)", "reported_id=%s reported_hash=%s expected=%s)",
tid, host_uuid, reported_id, reported_hash, expected, tid, host_uuid, reported_id, reported_hash, expected,
) )
except Exception: except SQLAlchemyError:
# Non-fatal: mutator reconcile loop will detect the mismatch again next heartbeat # Non-fatal: mutator reconcile loop will detect the mismatch again next heartbeat
log.exception("heartbeat: failed to flag resync tid=%s", tid) log.exception("heartbeat: failed to flag resync tid=%s", tid)