refactor(db): extract WebhooksMixin
Moves the 9 webhook-subscription methods (CRUD + delivery bookkeeping) into sqlmodel_repo/webhooks.py.
This commit is contained in:
@@ -53,7 +53,6 @@ from decnet.web.db.models import (
|
|||||||
OrchestratorEvent,
|
OrchestratorEvent,
|
||||||
RealismConfig,
|
RealismConfig,
|
||||||
SyntheticFile,
|
SyntheticFile,
|
||||||
WebhookSubscription,
|
|
||||||
CanaryBlob,
|
CanaryBlob,
|
||||||
CanaryToken,
|
CanaryToken,
|
||||||
CanaryTrigger,
|
CanaryTrigger,
|
||||||
@@ -70,6 +69,7 @@ from decnet.web.db.sqlmodel_repo.auth import AuthMixin
|
|||||||
from decnet.web.db.sqlmodel_repo.bounties import BountiesMixin
|
from decnet.web.db.sqlmodel_repo.bounties import BountiesMixin
|
||||||
from decnet.web.db.sqlmodel_repo.deckies import DeckiesMixin
|
from decnet.web.db.sqlmodel_repo.deckies import DeckiesMixin
|
||||||
from decnet.web.db.sqlmodel_repo.swarm import SwarmMixin
|
from decnet.web.db.sqlmodel_repo.swarm import SwarmMixin
|
||||||
|
from decnet.web.db.sqlmodel_repo.webhooks import WebhooksMixin
|
||||||
|
|
||||||
|
|
||||||
class SQLModelRepository(
|
class SQLModelRepository(
|
||||||
@@ -78,6 +78,7 @@ class SQLModelRepository(
|
|||||||
BountiesMixin,
|
BountiesMixin,
|
||||||
DeckiesMixin,
|
DeckiesMixin,
|
||||||
SwarmMixin,
|
SwarmMixin,
|
||||||
|
WebhooksMixin,
|
||||||
BaseRepository,
|
BaseRepository,
|
||||||
):
|
):
|
||||||
"""Concrete SQLModel/SQLAlchemy-async repository.
|
"""Concrete SQLModel/SQLAlchemy-async repository.
|
||||||
@@ -2396,128 +2397,6 @@ class SQLModelRepository(
|
|||||||
)
|
)
|
||||||
return [r for r in result.scalars().all()]
|
return [r for r in result.scalars().all()]
|
||||||
|
|
||||||
# --------------------------------------------------------- webhooks
|
|
||||||
|
|
||||||
async def create_webhook_subscription(self, data: dict[str, Any]) -> None:
|
|
||||||
async with self._session() as session:
|
|
||||||
session.add(WebhookSubscription(**data))
|
|
||||||
await session.commit()
|
|
||||||
|
|
||||||
async def get_webhook_subscription(
|
|
||||||
self, uuid: str
|
|
||||||
) -> Optional[dict[str, Any]]:
|
|
||||||
async with self._session() as session:
|
|
||||||
result = await session.execute(
|
|
||||||
select(WebhookSubscription).where(WebhookSubscription.uuid == uuid)
|
|
||||||
)
|
|
||||||
row = result.scalar_one_or_none()
|
|
||||||
return row.model_dump() if row else None
|
|
||||||
|
|
||||||
async def get_webhook_subscription_by_name(
|
|
||||||
self, name: str
|
|
||||||
) -> Optional[dict[str, Any]]:
|
|
||||||
async with self._session() as session:
|
|
||||||
result = await session.execute(
|
|
||||||
select(WebhookSubscription).where(WebhookSubscription.name == name)
|
|
||||||
)
|
|
||||||
row = result.scalar_one_or_none()
|
|
||||||
return row.model_dump() if row else None
|
|
||||||
|
|
||||||
async def list_webhook_subscriptions(
|
|
||||||
self, enabled_only: bool = False
|
|
||||||
) -> list[dict[str, Any]]:
|
|
||||||
async with self._session() as session:
|
|
||||||
stmt = select(WebhookSubscription)
|
|
||||||
if enabled_only:
|
|
||||||
stmt = stmt.where(WebhookSubscription.enabled.is_(True))
|
|
||||||
stmt = stmt.order_by(WebhookSubscription.created_at)
|
|
||||||
result = await session.execute(stmt)
|
|
||||||
return [r.model_dump() for r in result.scalars().all()]
|
|
||||||
|
|
||||||
async def update_webhook_subscription(
|
|
||||||
self, uuid: str, patch: dict[str, Any]
|
|
||||||
) -> bool:
|
|
||||||
if not patch:
|
|
||||||
return True
|
|
||||||
patch = {**patch, "updated_at": datetime.now(timezone.utc)}
|
|
||||||
async with self._session() as session:
|
|
||||||
result = await session.execute(
|
|
||||||
update(WebhookSubscription)
|
|
||||||
.where(WebhookSubscription.uuid == uuid)
|
|
||||||
.values(**patch)
|
|
||||||
)
|
|
||||||
await session.commit()
|
|
||||||
return result.rowcount > 0
|
|
||||||
|
|
||||||
async def delete_webhook_subscription(self, uuid: str) -> bool:
|
|
||||||
async with self._session() as session:
|
|
||||||
result = await session.execute(
|
|
||||||
select(WebhookSubscription).where(WebhookSubscription.uuid == uuid)
|
|
||||||
)
|
|
||||||
row = result.scalar_one_or_none()
|
|
||||||
if not row:
|
|
||||||
return False
|
|
||||||
await session.delete(row)
|
|
||||||
await session.commit()
|
|
||||||
return True
|
|
||||||
|
|
||||||
async def record_webhook_success(
|
|
||||||
self, uuid: str, ts: datetime
|
|
||||||
) -> None:
|
|
||||||
async with self._session() as session:
|
|
||||||
await session.execute(
|
|
||||||
update(WebhookSubscription)
|
|
||||||
.where(WebhookSubscription.uuid == uuid)
|
|
||||||
.values(
|
|
||||||
consecutive_failures=0,
|
|
||||||
last_success_at=ts,
|
|
||||||
last_error=None,
|
|
||||||
updated_at=ts,
|
|
||||||
)
|
|
||||||
)
|
|
||||||
await session.commit()
|
|
||||||
|
|
||||||
async def record_webhook_failure(
|
|
||||||
self, uuid: str, ts: datetime, error: str
|
|
||||||
) -> int:
|
|
||||||
async with self._session() as session:
|
|
||||||
# Read current failure count, bump, write. Small race window on
|
|
||||||
# concurrent deliveries to the same subscription is acceptable —
|
|
||||||
# the counter informs the circuit-breaker heuristic, not a
|
|
||||||
# correctness invariant.
|
|
||||||
result = await session.execute(
|
|
||||||
select(WebhookSubscription.consecutive_failures).where(
|
|
||||||
WebhookSubscription.uuid == uuid
|
|
||||||
)
|
|
||||||
)
|
|
||||||
current = result.scalar_one_or_none() or 0
|
|
||||||
new_count = current + 1
|
|
||||||
await session.execute(
|
|
||||||
update(WebhookSubscription)
|
|
||||||
.where(WebhookSubscription.uuid == uuid)
|
|
||||||
.values(
|
|
||||||
consecutive_failures=new_count,
|
|
||||||
last_failure_at=ts,
|
|
||||||
last_error=error[:512] if error else None,
|
|
||||||
updated_at=ts,
|
|
||||||
)
|
|
||||||
)
|
|
||||||
await session.commit()
|
|
||||||
return new_count
|
|
||||||
|
|
||||||
async def trip_webhook_circuit(self, uuid: str, ts: datetime) -> None:
|
|
||||||
async with self._session() as session:
|
|
||||||
await session.execute(
|
|
||||||
update(WebhookSubscription)
|
|
||||||
.where(WebhookSubscription.uuid == uuid)
|
|
||||||
.values(
|
|
||||||
enabled=False,
|
|
||||||
auto_disabled_at=ts,
|
|
||||||
updated_at=ts,
|
|
||||||
)
|
|
||||||
)
|
|
||||||
await session.commit()
|
|
||||||
|
|
||||||
# ---------------------------------------------------------- canary
|
# ---------------------------------------------------------- canary
|
||||||
|
|
||||||
async def upsert_canary_blob(self, data: dict[str, Any]) -> dict[str, Any]:
|
async def upsert_canary_blob(self, data: dict[str, Any]) -> dict[str, Any]:
|
||||||
|
|||||||
133
decnet/web/db/sqlmodel_repo/webhooks.py
Normal file
133
decnet/web/db/sqlmodel_repo/webhooks.py
Normal file
@@ -0,0 +1,133 @@
|
|||||||
|
"""Webhook subscription CRUD + delivery bookkeeping."""
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
from datetime import datetime, timezone
|
||||||
|
from typing import Any, Optional
|
||||||
|
|
||||||
|
from sqlalchemy import select, update
|
||||||
|
|
||||||
|
from decnet.web.db.models import WebhookSubscription
|
||||||
|
|
||||||
|
|
||||||
|
class WebhooksMixin:
|
||||||
|
"""Mixin: composed onto ``SQLModelRepository``."""
|
||||||
|
|
||||||
|
async def create_webhook_subscription(self, data: dict[str, Any]) -> None:
|
||||||
|
async with self._session() as session:
|
||||||
|
session.add(WebhookSubscription(**data))
|
||||||
|
await session.commit()
|
||||||
|
|
||||||
|
async def get_webhook_subscription(
|
||||||
|
self, uuid: str
|
||||||
|
) -> Optional[dict[str, Any]]:
|
||||||
|
async with self._session() as session:
|
||||||
|
result = await session.execute(
|
||||||
|
select(WebhookSubscription).where(WebhookSubscription.uuid == uuid)
|
||||||
|
)
|
||||||
|
row = result.scalar_one_or_none()
|
||||||
|
return row.model_dump() if row else None
|
||||||
|
|
||||||
|
async def get_webhook_subscription_by_name(
|
||||||
|
self, name: str
|
||||||
|
) -> Optional[dict[str, Any]]:
|
||||||
|
async with self._session() as session:
|
||||||
|
result = await session.execute(
|
||||||
|
select(WebhookSubscription).where(WebhookSubscription.name == name)
|
||||||
|
)
|
||||||
|
row = result.scalar_one_or_none()
|
||||||
|
return row.model_dump() if row else None
|
||||||
|
|
||||||
|
async def list_webhook_subscriptions(
|
||||||
|
self, enabled_only: bool = False
|
||||||
|
) -> list[dict[str, Any]]:
|
||||||
|
async with self._session() as session:
|
||||||
|
stmt = select(WebhookSubscription)
|
||||||
|
if enabled_only:
|
||||||
|
stmt = stmt.where(WebhookSubscription.enabled.is_(True))
|
||||||
|
stmt = stmt.order_by(WebhookSubscription.created_at)
|
||||||
|
result = await session.execute(stmt)
|
||||||
|
return [r.model_dump() for r in result.scalars().all()]
|
||||||
|
|
||||||
|
async def update_webhook_subscription(
|
||||||
|
self, uuid: str, patch: dict[str, Any]
|
||||||
|
) -> bool:
|
||||||
|
if not patch:
|
||||||
|
return True
|
||||||
|
patch = {**patch, "updated_at": datetime.now(timezone.utc)}
|
||||||
|
async with self._session() as session:
|
||||||
|
result = await session.execute(
|
||||||
|
update(WebhookSubscription)
|
||||||
|
.where(WebhookSubscription.uuid == uuid)
|
||||||
|
.values(**patch)
|
||||||
|
)
|
||||||
|
await session.commit()
|
||||||
|
return result.rowcount > 0
|
||||||
|
|
||||||
|
async def delete_webhook_subscription(self, uuid: str) -> bool:
|
||||||
|
async with self._session() as session:
|
||||||
|
result = await session.execute(
|
||||||
|
select(WebhookSubscription).where(WebhookSubscription.uuid == uuid)
|
||||||
|
)
|
||||||
|
row = result.scalar_one_or_none()
|
||||||
|
if not row:
|
||||||
|
return False
|
||||||
|
await session.delete(row)
|
||||||
|
await session.commit()
|
||||||
|
return True
|
||||||
|
|
||||||
|
async def record_webhook_success(
|
||||||
|
self, uuid: str, ts: datetime
|
||||||
|
) -> None:
|
||||||
|
async with self._session() as session:
|
||||||
|
await session.execute(
|
||||||
|
update(WebhookSubscription)
|
||||||
|
.where(WebhookSubscription.uuid == uuid)
|
||||||
|
.values(
|
||||||
|
consecutive_failures=0,
|
||||||
|
last_success_at=ts,
|
||||||
|
last_error=None,
|
||||||
|
updated_at=ts,
|
||||||
|
)
|
||||||
|
)
|
||||||
|
await session.commit()
|
||||||
|
|
||||||
|
async def record_webhook_failure(
|
||||||
|
self, uuid: str, ts: datetime, error: str
|
||||||
|
) -> int:
|
||||||
|
async with self._session() as session:
|
||||||
|
# Read current failure count, bump, write. Small race window on
|
||||||
|
# concurrent deliveries to the same subscription is acceptable —
|
||||||
|
# the counter informs the circuit-breaker heuristic, not a
|
||||||
|
# correctness invariant.
|
||||||
|
result = await session.execute(
|
||||||
|
select(WebhookSubscription.consecutive_failures).where(
|
||||||
|
WebhookSubscription.uuid == uuid
|
||||||
|
)
|
||||||
|
)
|
||||||
|
current = result.scalar_one_or_none() or 0
|
||||||
|
new_count = current + 1
|
||||||
|
await session.execute(
|
||||||
|
update(WebhookSubscription)
|
||||||
|
.where(WebhookSubscription.uuid == uuid)
|
||||||
|
.values(
|
||||||
|
consecutive_failures=new_count,
|
||||||
|
last_failure_at=ts,
|
||||||
|
last_error=error[:512] if error else None,
|
||||||
|
updated_at=ts,
|
||||||
|
)
|
||||||
|
)
|
||||||
|
await session.commit()
|
||||||
|
return new_count
|
||||||
|
|
||||||
|
async def trip_webhook_circuit(self, uuid: str, ts: datetime) -> None:
|
||||||
|
async with self._session() as session:
|
||||||
|
await session.execute(
|
||||||
|
update(WebhookSubscription)
|
||||||
|
.where(WebhookSubscription.uuid == uuid)
|
||||||
|
.values(
|
||||||
|
enabled=False,
|
||||||
|
auto_disabled_at=ts,
|
||||||
|
updated_at=ts,
|
||||||
|
)
|
||||||
|
)
|
||||||
|
await session.commit()
|
||||||
Reference in New Issue
Block a user