fix(security): close MEDIUM ASVS findings — JWT pinning, SSE tickets, SSRF, mTLS pin, rate limits + correctness bugs
Auth (V2.1.1/V3.1.2, V2.1.3, V3.1.1): - Pin JWT iss/aud/typ at mint and require+verify them at decode; revocation (jti denylist + tokens_valid_from) still enforced. - Change-password now requires min_length=12. - SSE auth moves off JWT-in-URL to a single-use 60s opaque ticket (POST /auth/sse-ticket); raw JWT in query no longer authenticates a stream. Removed dead fail-open get_stream_user helper. Egress (V5.1.1, V9.1.1/V14.1.3): - Webhook delivery + CRUD reject SSRF destinations (private/loopback/link-local/ metadata, IPv4-mapped, multi-A-record) via resolved-IP validation, pin to the vetted IP, and never auto-follow redirects. Opt-out via DECNET_WEBHOOK_ALLOW_PRIVATE. - UpdaterClient pins the worker leaf cert SHA-256 against the stored per-host fingerprint (fail closed on missing/mismatch); DECNET_VERIFY_HOSTNAME now defaults True. Hardening (V13.1.3, V4.1.4, V13.1.2): - Rate-limit change-password (5/min), enroll-bundle (10/min), webhook-create (20/min), host-delete (20/min) via the existing slowapi limiter. - Correct false 'global auth middleware' comment; document enroll-bundle proxy trust. Correctness (BUG-7..11): - BUG-7 unbound bus in finally; BUG-8 apply_ceiling clamps to min(base,ceiling); BUG-9 commit before emit; BUG-10 multi-actor rearm for sub-threshold identities; BUG-11 normalize naive timestamps to UTC. Already-closed (no change): V14.1.1, V2.1.2/V3.1.3, V5.1.2. Tests added for every fix; unanimous adversarial review.
This commit is contained in:
@@ -11,6 +11,14 @@ SECRET_KEY: str = DECNET_JWT_SECRET
|
||||
ALGORITHM: str = "HS256"
|
||||
ACCESS_TOKEN_EXPIRE_MINUTES: int = DECNET_JWT_EXP_MINUTES
|
||||
|
||||
# Pinned issuer/audience/type so a token signed with DECNET_JWT_SECRET for any
|
||||
# OTHER purpose (or by a future co-tenant of the secret) is not accepted by the
|
||||
# dashboard verifier. Issuance stamps these; _decode_payload requires + verifies
|
||||
# them. Keep these two modules in lockstep — they are a single trust contract.
|
||||
JWT_ISSUER: str = "decnet"
|
||||
JWT_AUDIENCE: str = "decnet-dashboard"
|
||||
JWT_TYPE: str = "access"
|
||||
|
||||
|
||||
def verify_password(plain_password: str, hashed_password: str) -> bool:
|
||||
return bcrypt.checkpw(
|
||||
@@ -45,5 +53,10 @@ def create_access_token(data: dict[str, Any], expires_delta: Optional[timedelta]
|
||||
|
||||
_to_encode.update({"exp": _expire})
|
||||
_to_encode.update({"iat": datetime.now(timezone.utc)})
|
||||
# Pin issuer / audience / token-type so the verifier can reject tokens
|
||||
# minted for any other purpose with the same shared secret.
|
||||
_to_encode.setdefault("iss", JWT_ISSUER)
|
||||
_to_encode.setdefault("aud", JWT_AUDIENCE)
|
||||
_to_encode.setdefault("typ", JWT_TYPE)
|
||||
_encoded_jwt: str = jwt.encode(_to_encode, SECRET_KEY, algorithm=ALGORITHM)
|
||||
return _encoded_jwt
|
||||
|
||||
@@ -50,7 +50,18 @@ class LoginRequest(BaseModel):
|
||||
|
||||
class ChangePasswordRequest(BaseModel):
|
||||
old_password: str = PydanticField(..., max_length=72)
|
||||
new_password: str = PydanticField(..., max_length=72)
|
||||
# min_length=12 aligns with the DECNET_ADMIN_PASSWORD >=12 policy. The
|
||||
# forced first-login flow routes through /auth/change-password, so without a
|
||||
# floor a seeded admin could clear must_change_password with a 1-char secret.
|
||||
new_password: str = PydanticField(..., min_length=12, max_length=72)
|
||||
|
||||
|
||||
class SSETicketResponse(BaseModel):
|
||||
"""Single-use, short-lived opaque ticket the dashboard exchanges its header
|
||||
JWT for, then passes to an SSE endpoint as ?ticket= (EventSource cannot set
|
||||
an Authorization header). See decnet.web.dependencies SSE ticket store."""
|
||||
ticket: str
|
||||
expires_in: int
|
||||
|
||||
|
||||
# --- Configuration Models ---
|
||||
|
||||
@@ -1,5 +1,6 @@
|
||||
# SPDX-License-Identifier: AGPL-3.0-or-later
|
||||
import asyncio
|
||||
import secrets
|
||||
import time
|
||||
from datetime import datetime, timezone
|
||||
from typing import Any, Optional
|
||||
@@ -8,7 +9,13 @@ import jwt
|
||||
from fastapi import HTTPException, status, Request
|
||||
from fastapi.security import OAuth2PasswordBearer
|
||||
|
||||
from decnet.web.auth import ALGORITHM, SECRET_KEY
|
||||
from decnet.web.auth import (
|
||||
ALGORITHM,
|
||||
JWT_AUDIENCE,
|
||||
JWT_ISSUER,
|
||||
JWT_TYPE,
|
||||
SECRET_KEY,
|
||||
)
|
||||
from decnet.web.db.repository import BaseRepository
|
||||
from decnet.web.db.factory import get_repository
|
||||
|
||||
@@ -168,13 +175,30 @@ def _epoch(value: Any) -> float:
|
||||
|
||||
|
||||
def _decode_payload(token: str) -> dict[str, Any]:
|
||||
"""Decode + signature/expiry-verify a raw JWT, or raise 401."""
|
||||
"""Decode + signature/expiry-verify a raw JWT, or raise 401.
|
||||
|
||||
Beyond signature + expiry, this pins the issuer and audience and requires
|
||||
the registered claims to be present, so a token minted with the same shared
|
||||
secret for a different purpose (or omitting exp/iat/iss/aud) is rejected.
|
||||
``uuid`` (not ``sub``) is this app's identity claim, so it is in ``require``.
|
||||
``typ`` is a custom payload claim PyJWT does not validate natively, so it is
|
||||
checked explicitly below.
|
||||
"""
|
||||
try:
|
||||
payload: dict[str, Any] = jwt.decode(token, SECRET_KEY, algorithms=[ALGORITHM])
|
||||
payload: dict[str, Any] = jwt.decode(
|
||||
token,
|
||||
SECRET_KEY,
|
||||
algorithms=[ALGORITHM],
|
||||
audience=JWT_AUDIENCE,
|
||||
issuer=JWT_ISSUER,
|
||||
options={"require": ["exp", "iat", "iss", "aud", "uuid"]},
|
||||
)
|
||||
except jwt.PyJWTError:
|
||||
raise _CREDENTIALS_EXCEPTION
|
||||
if payload.get("uuid") is None:
|
||||
raise _CREDENTIALS_EXCEPTION
|
||||
if payload.get("typ") != JWT_TYPE:
|
||||
raise _CREDENTIALS_EXCEPTION
|
||||
return payload
|
||||
|
||||
|
||||
@@ -236,17 +260,70 @@ async def get_token_claims(request: Request) -> dict[str, Any]:
|
||||
return _decode_payload(token)
|
||||
|
||||
|
||||
async def get_stream_user(request: Request, token: Optional[str] = None) -> str:
|
||||
"""Auth dependency for SSE endpoints — accepts Bearer header OR ?token= query param.
|
||||
EventSource does not support custom headers, so the query-string fallback is intentional here only.
|
||||
# ---------------------------------------------------------------------------
|
||||
# SSE stream tickets (V3.1.1)
|
||||
# ---------------------------------------------------------------------------
|
||||
# EventSource cannot set an Authorization header, so SSE auth historically rode
|
||||
# in ?token=<JWT>, leaking the full-lifetime bearer into access/proxy logs,
|
||||
# browser history, and Referer. Instead the client exchanges its header JWT for
|
||||
# a single-use, short-lived OPAQUE ticket via POST /api/v1/auth/sse-ticket and
|
||||
# connects with ?ticket=<opaque>. The JWT never appears in any URL.
|
||||
#
|
||||
# Security-boundary store — FAIL CLOSED. The map is keyed on the opaque ticket
|
||||
# and holds (expiry_monotonic, bound_identity). Redemption validates presence +
|
||||
# freshness, then DELETES the entry (single-use). Unknown / expired / reused
|
||||
# tickets all resolve to 401.
|
||||
#
|
||||
# This is a MODULE-LEVEL dict: tickets live only in the process that minted
|
||||
# them. A multi-process / multi-worker deployment needs a SHARED store (Redis,
|
||||
# DB) so a ticket minted on worker A can be redeemed on worker B — out of scope
|
||||
# here, deliberately. No background sweeper daemon (project rule: library, not
|
||||
# new worker); expiry is enforced opportunistically on every redeem + mint.
|
||||
_SSE_TICKET_TTL = 60.0 # seconds
|
||||
_sse_tickets: dict[str, tuple[float, dict[str, Any]]] = {}
|
||||
|
||||
|
||||
def _reset_sse_tickets() -> None:
|
||||
"""Test hook: drop all outstanding stream tickets."""
|
||||
_sse_tickets.clear()
|
||||
|
||||
|
||||
def _sweep_sse_tickets(now: Optional[float] = None) -> None:
|
||||
"""Opportunistic eviction of expired tickets. O(n) over a tiny map (tickets
|
||||
are single-use and 60s-lived), called on every mint/redeem — no daemon."""
|
||||
_now = time.monotonic() if now is None else now
|
||||
expired = [t for t, (exp, _) in _sse_tickets.items() if exp <= _now]
|
||||
for t in expired:
|
||||
_sse_tickets.pop(t, None)
|
||||
|
||||
|
||||
def mint_sse_ticket(user_uuid: str, role: str) -> str:
|
||||
"""Mint a single-use, 60s opaque SSE ticket bound to ``user_uuid``+``role``.
|
||||
|
||||
Called by POST /auth/sse-ticket AFTER the header JWT has been validated, so
|
||||
the bound identity is already trusted. Returns the opaque token the client
|
||||
passes as ?ticket=. Sweeps expired entries on the way in.
|
||||
"""
|
||||
resolved = _bearer_from_header(request) or token
|
||||
if not resolved:
|
||||
_sweep_sse_tickets()
|
||||
ticket = secrets.token_urlsafe(32)
|
||||
expiry = time.monotonic() + _SSE_TICKET_TTL
|
||||
_sse_tickets[ticket] = (expiry, {"uuid": user_uuid, "role": role})
|
||||
return ticket
|
||||
|
||||
|
||||
def _redeem_sse_ticket(ticket: str) -> dict[str, Any]:
|
||||
"""Redeem a stream ticket: validate exists + unexpired, then DELETE it
|
||||
(single-use). Returns the bound ``{"uuid","role"}`` identity or raises 401.
|
||||
Fail closed: unknown / expired / already-redeemed all raise."""
|
||||
now = time.monotonic()
|
||||
_sweep_sse_tickets(now)
|
||||
entry = _sse_tickets.pop(ticket, None) # pop = single-use, even on expiry
|
||||
if entry is None:
|
||||
raise _CREDENTIALS_EXCEPTION
|
||||
# Decode-only: returns the uuid. Revocation/role enforcement happens in
|
||||
# require_stream_role (the sole production caller), which runs the full
|
||||
# _resolve_token path. Kept thin so its decode contract stays unit-testable.
|
||||
return _decode_payload(resolved)["uuid"]
|
||||
expiry, identity = entry
|
||||
if expiry <= now:
|
||||
raise _CREDENTIALS_EXCEPTION
|
||||
return identity
|
||||
|
||||
|
||||
async def get_current_user(request: Request) -> str:
|
||||
@@ -298,18 +375,35 @@ def require_role(*allowed_roles: str):
|
||||
|
||||
|
||||
def require_stream_role(*allowed_roles: str):
|
||||
"""Like ``require_role`` but for SSE endpoints that accept a query-param token."""
|
||||
async def _check(request: Request, token: Optional[str] = None) -> dict:
|
||||
resolved = _bearer_from_header(request) or token
|
||||
if not resolved:
|
||||
"""Like ``require_role`` but for SSE endpoints.
|
||||
|
||||
Two ingress paths:
|
||||
* Bearer header → full ``_resolve_token`` (revocation + cutoff enforced).
|
||||
* ?ticket=<opaque> → single-use stream ticket minted by /auth/sse-ticket,
|
||||
which already validated the header JWT and bound the uuid+role. The
|
||||
ticket carries no jti, so the per-token denylist cannot apply here; the
|
||||
60s single-use lifetime is the bounded exposure we accept for SSE.
|
||||
|
||||
Raw ?token=<JWT> is intentionally NOT accepted (V3.1.1)."""
|
||||
async def _check(request: Request, ticket: Optional[str] = None) -> dict:
|
||||
header_token = _bearer_from_header(request)
|
||||
if header_token:
|
||||
_user_uuid, user = await _resolve_token(header_token)
|
||||
if user["role"] not in allowed_roles:
|
||||
raise HTTPException(
|
||||
status_code=status.HTTP_403_FORBIDDEN,
|
||||
detail="Insufficient permissions",
|
||||
)
|
||||
return user
|
||||
if not ticket:
|
||||
raise _CREDENTIALS_EXCEPTION
|
||||
_user_uuid, user = await _resolve_token(resolved)
|
||||
if user["role"] not in allowed_roles:
|
||||
identity = _redeem_sse_ticket(ticket)
|
||||
if identity["role"] not in allowed_roles:
|
||||
raise HTTPException(
|
||||
status_code=status.HTTP_403_FORBIDDEN,
|
||||
detail="Insufficient permissions",
|
||||
)
|
||||
return user
|
||||
return identity
|
||||
return _check
|
||||
|
||||
|
||||
|
||||
@@ -4,6 +4,7 @@ from fastapi import APIRouter
|
||||
from .auth.api_login import router as login_router
|
||||
from .auth.api_change_pass import router as change_pass_router
|
||||
from .auth.api_logout import router as logout_router
|
||||
from .auth.api_sse_ticket import router as sse_ticket_router
|
||||
from .logs.api_get_logs import router as logs_router
|
||||
from .logs.api_get_histogram import router as histogram_router
|
||||
from .bounty.api_get_bounties import router as bounty_router
|
||||
@@ -75,9 +76,12 @@ from .ttp.api_export_navigator import router as ttp_navigator_router
|
||||
from .ttp.api_get_groups_for_technique import router as ttp_groups_for_technique_router
|
||||
|
||||
api_router = APIRouter(
|
||||
# Every route under /api/v1 is auth-guarded (either by an explicit
|
||||
# require_* Depends or by the global auth middleware). Document 401/403
|
||||
# here so the OpenAPI schema reflects reality for contract tests.
|
||||
# Auth is enforced PER ROUTE via explicit ``require_*`` Depends (see
|
||||
# decnet.web.dependencies) — there is NO global auth middleware. A route
|
||||
# without a require_* dependency is unauthenticated BY DESIGN; the only such
|
||||
# routes are /health (liveness) and /auth/login (credential exchange).
|
||||
# The 401/403 entries below are documented here so the OpenAPI schema
|
||||
# reflects reality for contract tests, not because a middleware applies them.
|
||||
responses={
|
||||
400: {"description": "Malformed request body"},
|
||||
401: {"description": "Missing or invalid credentials"},
|
||||
@@ -91,6 +95,7 @@ api_router = APIRouter(
|
||||
api_router.include_router(login_router)
|
||||
api_router.include_router(change_pass_router)
|
||||
api_router.include_router(logout_router)
|
||||
api_router.include_router(sse_ticket_router)
|
||||
|
||||
# Logs & Analytics
|
||||
api_router.include_router(logs_router)
|
||||
|
||||
@@ -10,8 +10,9 @@ stream's attacker. Emits a one-shot snapshot on connect (latest
|
||||
observation per primitive) so the panel hydrates immediately.
|
||||
|
||||
Authorization mirrors :mod:`decnet.web.router.topology.api_events` —
|
||||
JWT via the ``?token=`` query parameter (EventSource can't set
|
||||
arbitrary headers) + ``require_stream_viewer`` role gate. The 404
|
||||
a single-use opaque ticket via the ``?ticket=`` query parameter
|
||||
(EventSource can't set arbitrary headers) + ``require_stream_viewer``
|
||||
role gate. The 404
|
||||
fires after auth so an existence probe can't leak an attacker UUID
|
||||
to an unauthenticated caller.
|
||||
|
||||
|
||||
@@ -2,12 +2,13 @@
|
||||
from datetime import datetime, timezone
|
||||
from typing import Any, Optional
|
||||
|
||||
from fastapi import APIRouter, Depends, HTTPException, status
|
||||
from fastapi import APIRouter, Depends, HTTPException, Request, status
|
||||
|
||||
from decnet.telemetry import traced as _traced
|
||||
from decnet.web.auth import ahash_password, averify_password
|
||||
from decnet.web.dependencies import get_current_user_unchecked, invalidate_user_cache, repo
|
||||
from decnet.web.db.models import ChangePasswordRequest, MessageResponse
|
||||
from decnet.web.limiter import limiter
|
||||
|
||||
router = APIRouter()
|
||||
|
||||
@@ -19,19 +20,21 @@ router = APIRouter()
|
||||
responses={
|
||||
400: {"description": "Bad Request (e.g. malformed JSON)"},
|
||||
401: {"description": "Could not validate credentials"},
|
||||
422: {"description": "Validation error"}
|
||||
422: {"description": "Validation error"},
|
||||
429: {"description": "Too many password-change attempts — retry after the window resets"},
|
||||
},
|
||||
)
|
||||
@limiter.limit("5/minute")
|
||||
@_traced("api.change_password")
|
||||
async def change_password(request: ChangePasswordRequest, current_user: str = Depends(get_current_user_unchecked)) -> dict[str, str]:
|
||||
async def change_password(request: Request, body: ChangePasswordRequest, current_user: str = Depends(get_current_user_unchecked)) -> dict[str, str]:
|
||||
_user: Optional[dict[str, Any]] = await repo.get_user_by_uuid(current_user)
|
||||
if not _user or not await averify_password(request.old_password, _user["password_hash"]):
|
||||
if not _user or not await averify_password(body.old_password, _user["password_hash"]):
|
||||
raise HTTPException(
|
||||
status_code=status.HTTP_401_UNAUTHORIZED,
|
||||
detail="Incorrect old password",
|
||||
)
|
||||
|
||||
_new_hash: str = await ahash_password(request.new_password)
|
||||
_new_hash: str = await ahash_password(body.new_password)
|
||||
await repo.update_user_password(current_user, _new_hash, must_change_password=False)
|
||||
# Changing a password revokes every existing session for this user (incl.
|
||||
# the current one): the caller's next request 401s and re-authenticates.
|
||||
|
||||
39
decnet/web/router/auth/api_sse_ticket.py
Normal file
39
decnet/web/router/auth/api_sse_ticket.py
Normal file
@@ -0,0 +1,39 @@
|
||||
# SPDX-License-Identifier: AGPL-3.0-or-later
|
||||
"""Mint a single-use, short-lived SSE stream ticket (V3.1.1).
|
||||
|
||||
EventSource cannot send an Authorization header, so SSE auth used to ride in
|
||||
``?token=<JWT>`` — leaking the full-lifetime bearer into access/proxy logs,
|
||||
browser history, and Referer. This endpoint lets an already-authenticated
|
||||
client (gated by the NORMAL header JWT via ``require_viewer``) exchange that
|
||||
header credential for an opaque ``secrets.token_urlsafe(32)`` ticket, valid for
|
||||
60s and single-use, which it then passes to the SSE endpoint as ``?ticket=``.
|
||||
The JWT never appears in any URL.
|
||||
|
||||
The ticket store lives in-process (decnet.web.dependencies); multi-process
|
||||
deployments need a shared store — out of scope, see that module's note.
|
||||
"""
|
||||
from fastapi import APIRouter, Depends
|
||||
|
||||
from decnet.telemetry import traced as _traced
|
||||
from decnet.web.dependencies import mint_sse_ticket, require_viewer, _SSE_TICKET_TTL
|
||||
from decnet.web.db.models.auth import SSETicketResponse
|
||||
|
||||
router = APIRouter()
|
||||
|
||||
|
||||
@router.post(
|
||||
"/auth/sse-ticket",
|
||||
tags=["Authentication"],
|
||||
response_model=SSETicketResponse,
|
||||
responses={
|
||||
400: {"description": "Malformed request body"},
|
||||
401: {"description": "Missing or invalid credentials"},
|
||||
403: {"description": "Authenticated but not authorized"},
|
||||
},
|
||||
)
|
||||
@_traced("api.sse_ticket")
|
||||
async def mint_stream_ticket(user: dict = Depends(require_viewer)) -> SSETicketResponse:
|
||||
"""Exchange the presented header JWT for a single-use 60s SSE ticket bound to
|
||||
this user's uuid + role. Any authenticated (viewer or admin) user may mint."""
|
||||
ticket = mint_sse_ticket(user["uuid"], user["role"])
|
||||
return SSETicketResponse(ticket=ticket, expires_in=int(_SSE_TICKET_TTL))
|
||||
@@ -6,8 +6,9 @@ request and forwards each matching event as a Server-Sent Event.
|
||||
Emits a one-shot snapshot on connect (current paginated campaign
|
||||
list).
|
||||
|
||||
Mirror of :mod:`decnet.web.router.identities.api_events`. Auth: JWT
|
||||
via ``?token=`` query param + ``require_stream_viewer`` role.
|
||||
Mirror of :mod:`decnet.web.router.identities.api_events`. Auth:
|
||||
single-use opaque ticket via ``?ticket=`` query param +
|
||||
``require_stream_viewer`` role.
|
||||
"""
|
||||
from __future__ import annotations
|
||||
|
||||
|
||||
@@ -8,8 +8,9 @@ Server-Sent Event to the browser. Emits a one-shot snapshot on connect
|
||||
fetch to initialise.
|
||||
|
||||
Authorization mirrors :mod:`decnet.web.router.topology.api_events` — a
|
||||
JWT passed via the ``?token=`` query parameter (EventSource can't set
|
||||
arbitrary headers) + ``require_stream_viewer`` role gate.
|
||||
single-use opaque ticket passed via the ``?ticket=`` query parameter
|
||||
(EventSource can't set arbitrary headers) + ``require_stream_viewer``
|
||||
role gate.
|
||||
|
||||
The endpoint is broadly scoped (every identity event, not per-uuid)
|
||||
because both ``AttackerDetail`` and ``IdentityDetail`` need the same
|
||||
|
||||
@@ -12,12 +12,13 @@ from __future__ import annotations
|
||||
|
||||
import pathlib
|
||||
|
||||
from fastapi import APIRouter, Depends, HTTPException, status
|
||||
from fastapi import APIRouter, Depends, HTTPException, Request, status
|
||||
|
||||
from decnet.logging import get_logger
|
||||
from decnet.swarm.client import AgentClient
|
||||
from decnet.web.db.repository import BaseRepository
|
||||
from decnet.web.dependencies import get_repo, require_admin
|
||||
from decnet.web.limiter import limiter
|
||||
from decnet.web.router.swarm._mtls import PeerCert, require_operator_cert
|
||||
|
||||
log = get_logger("swarm.decommission")
|
||||
@@ -32,10 +33,13 @@ router = APIRouter()
|
||||
401: {"description": "Missing or invalid admin JWT"},
|
||||
403: {"description": "Authenticated user is not an admin, or operator cert missing"},
|
||||
404: {"description": "No host with this UUID is enrolled"},
|
||||
429: {"description": "Too many decommission requests — retry after the window resets"},
|
||||
},
|
||||
)
|
||||
@limiter.limit("20/minute")
|
||||
async def api_decommission_host(
|
||||
uuid: str,
|
||||
request: Request,
|
||||
repo: BaseRepository = Depends(get_repo),
|
||||
_admin: dict = Depends(require_admin),
|
||||
_operator: PeerCert = Depends(require_operator_cert),
|
||||
|
||||
@@ -34,6 +34,7 @@ from decnet.swarm.bundle_builder import build_tarball, render_bootstrap
|
||||
from decnet.web.db.models.swarm import EnrollBundleRequest, EnrollBundleResponse
|
||||
from decnet.web.db.repository import BaseRepository
|
||||
from decnet.web.dependencies import get_repo, require_admin
|
||||
from decnet.web.limiter import limiter
|
||||
|
||||
log = get_logger("swarm_mgmt.enroll_bundle")
|
||||
|
||||
@@ -117,8 +118,10 @@ async def _lookup_live(token: str) -> _Bundle:
|
||||
403: {"description": "Insufficient permissions"},
|
||||
409: {"description": "A worker with this name is already enrolled"},
|
||||
422: {"description": "Request body validation error"},
|
||||
429: {"description": "Too many enroll-bundle requests — retry after the window resets"},
|
||||
},
|
||||
)
|
||||
@limiter.limit("10/minute")
|
||||
async def create_enroll_bundle(
|
||||
req: EnrollBundleRequest,
|
||||
request: Request,
|
||||
@@ -251,6 +254,14 @@ async def get_payload(
|
||||
# The agent's first connect-back — its source IP is the reachable address
|
||||
# the master will later use to probe it. Backfill the SwarmHost row here
|
||||
# so the operator sees the real address instead of an empty placeholder.
|
||||
#
|
||||
# PROXY TRUST WARNING: `request.client.host` is the TCP peer's IP.
|
||||
# If this endpoint sits behind a TCP-terminating reverse proxy (nginx,
|
||||
# HAProxy, etc.) the recorded address will be the proxy's IP, not the
|
||||
# agent's. Either bind the API directly on the network reachable by
|
||||
# agents, or configure the proxy to preserve the original source IP
|
||||
# (e.g. PROXY Protocol on a loopback listener, *not* X-Forwarded-For
|
||||
# which is trivially spoofable). See THREAT_MODEL.md §DA-08.
|
||||
client_host = request.client.host if request.client else ""
|
||||
if client_host:
|
||||
try:
|
||||
|
||||
@@ -8,8 +8,9 @@ a Server-Sent Event to the browser. Emits a one-shot snapshot on connect
|
||||
separate fetch to initialise the "pending" buffer.
|
||||
|
||||
Authorization matches :mod:`decnet.web.router.stream.api_stream_events`
|
||||
— a JWT passed via the ``?token=`` query parameter (EventSource can't
|
||||
set arbitrary headers) + ``require_stream_viewer`` role gate. The
|
||||
— a single-use opaque ticket passed via the ``?ticket=`` query
|
||||
parameter (EventSource can't set arbitrary headers) +
|
||||
``require_stream_viewer`` role gate. The
|
||||
per-topology 404 is enforced after auth so existence probes can't leak
|
||||
a topology id to an unauthenticated caller.
|
||||
"""
|
||||
|
||||
@@ -7,7 +7,7 @@ import secrets
|
||||
from datetime import datetime, timezone
|
||||
from typing import Any, cast
|
||||
|
||||
from fastapi import APIRouter, Depends, HTTPException
|
||||
from fastapi import APIRouter, Depends, HTTPException, Request
|
||||
|
||||
from decnet.bus import topics as _topics
|
||||
from decnet.bus.app import get_app_bus
|
||||
@@ -22,13 +22,28 @@ from decnet.web.db.models import (
|
||||
)
|
||||
from decnet.web.db.models.webhooks import _row_to_response_dict
|
||||
from decnet.web.dependencies import repo, require_admin
|
||||
from decnet.web.limiter import limiter
|
||||
from decnet.webhook.enums import merge_patterns
|
||||
from decnet.webhook.ssrf import WebhookDestinationError, validate_webhook_url
|
||||
|
||||
log = get_logger("api.webhooks")
|
||||
|
||||
router = APIRouter()
|
||||
|
||||
|
||||
def _validate_url_or_422(url: str) -> None:
|
||||
"""Reject a webhook URL that resolves to a forbidden destination.
|
||||
|
||||
Runs the same SSRF guard the delivery path enforces, but at
|
||||
registration time so a bad URL is surfaced to the operator as a clear
|
||||
422 instead of being silently dropped on every delivery attempt.
|
||||
"""
|
||||
try:
|
||||
validate_webhook_url(url)
|
||||
except WebhookDestinationError as e:
|
||||
raise HTTPException(status_code=422, detail=str(e)) from e
|
||||
|
||||
|
||||
async def _notify_subscriptions_changed() -> None:
|
||||
"""Publish `system.webhook.subscriptions_changed` on the bus.
|
||||
|
||||
@@ -60,10 +75,14 @@ def _row_to_response(row: dict[str, Any]) -> WebhookResponse:
|
||||
responses={
|
||||
400: {"description": "At least one of simple_events / topic_patterns required"},
|
||||
409: {"description": "Name already in use"},
|
||||
422: {"description": "URL resolves to a forbidden (internal) destination"},
|
||||
429: {"description": "Too many webhook-create requests — retry after the window resets"},
|
||||
},
|
||||
)
|
||||
@limiter.limit("20/minute")
|
||||
@_traced("api.webhook.create")
|
||||
async def api_create_webhook(
|
||||
request: Request,
|
||||
req: WebhookCreateRequest,
|
||||
admin: dict = Depends(require_admin),
|
||||
) -> WebhookCreateResponse:
|
||||
@@ -78,6 +97,8 @@ async def api_create_webhook(
|
||||
if existing:
|
||||
raise HTTPException(status_code=409, detail="Webhook name already exists")
|
||||
|
||||
_validate_url_or_422(str(req.url))
|
||||
|
||||
# Auto-generate a URL-safe secret if the caller didn't provide one.
|
||||
# 32 bytes of os-entropy is the same ballpark as a CSRF token.
|
||||
secret = req.secret or secrets.token_urlsafe(32)
|
||||
@@ -146,6 +167,7 @@ async def api_get_webhook(
|
||||
400: {"description": "Empty or invalid patch"},
|
||||
404: {"description": "Webhook not found"},
|
||||
409: {"description": "Name already in use"},
|
||||
422: {"description": "URL resolves to a forbidden (internal) destination"},
|
||||
},
|
||||
)
|
||||
@_traced("api.webhook.update")
|
||||
@@ -167,6 +189,7 @@ async def api_update_webhook(
|
||||
patch["name"] = req.name
|
||||
|
||||
if req.url is not None:
|
||||
_validate_url_or_422(str(req.url))
|
||||
patch["url"] = str(req.url)
|
||||
|
||||
if req.secret is not None:
|
||||
|
||||
Reference in New Issue
Block a user