Refactor: implemented Repository Factory and Async Mutator Engine. Decoupled storage logic and enforced Dependency Injection across CLI and Web API. Updated documentation.

decnet/web/router/auth/api_change_pass.py

@@ -12,7 +12,11 @@ router = APIRouter()
 @router.post(
     "/auth/change-password",
     tags=["Authentication"],
-    responses={401: {"description": "Invalid or expired token / wrong old password"}, 422: {"description": "Validation error"}},
+    responses={
+        400: {"description": "Bad Request (e.g. malformed JSON)"},
+        401: {"description": "Could not validate credentials"},
+        422: {"description": "Validation error"}
+    },
 )
 async def change_password(request: ChangePasswordRequest, current_user: str = Depends(get_current_user)) -> dict[str, str]:
     _user: Optional[dict[str, Any]] = await repo.get_user_by_uuid(current_user)
@@ -21,7 +25,7 @@ async def change_password(request: ChangePasswordRequest, current_user: str = De
             status_code=status.HTTP_401_UNAUTHORIZED,
             detail="Incorrect old password",
         )
-    
+
     _new_hash: str = get_password_hash(request.new_password)
     await repo.update_user_password(current_user, _new_hash, must_change_password=False)
     return {"message": "Password updated successfully"}

decnet/web/router/auth/api_login.py

@@ -18,7 +18,11 @@ router = APIRouter()
     "/auth/login",
     response_model=Token,
     tags=["Authentication"],
-    responses={401: {"description": "Incorrect username or password"}, 422: {"description": "Validation error"}},
+    responses={
+        400: {"description": "Bad Request (e.g. malformed JSON)"},
+        401: {"description": "Incorrect username or password"},
+        422: {"description": "Validation error"}
+    },
 )
 async def login(request: LoginRequest) -> dict[str, Any]:
     _user: Optional[dict[str, Any]] = await repo.get_user_by_username(request.username)
@@ -35,7 +39,7 @@ async def login(request: LoginRequest) -> dict[str, Any]:
         data={"uuid": _user["uuid"]}, expires_delta=_access_token_expires
     )
     return {
-        "access_token": _access_token, 
+        "access_token": _access_token,
         "token_type": "bearer",  # nosec B105
         "must_change_password": bool(_user.get("must_change_password", False))
     }

decnet/web/router/bounty/api_get_bounties.py

@@ -9,7 +9,7 @@ router = APIRouter()
 
 
 @router.get("/bounty", response_model=BountyResponse, tags=["Bounty Vault"],
-    responses={401: {"description": "Not authenticated"}, 422: {"description": "Validation error"}},)
+    responses={401: {"description": "Could not validate credentials"}, 422: {"description": "Validation error"}},)
 async def get_bounties(
     limit: int = Query(50, ge=1, le=1000),
     offset: int = Query(0, ge=0),

decnet/web/router/fleet/api_deploy_deckies.py

@@ -3,17 +3,21 @@ import os
 
 from fastapi import APIRouter, Depends, HTTPException
 
-from decnet.config import DEFAULT_MUTATE_INTERVAL, DecnetConfig, load_state
+from decnet.config import DEFAULT_MUTATE_INTERVAL, DecnetConfig, _ROOT
 from decnet.engine import deploy as _deploy
 from decnet.ini_loader import load_ini_from_string
 from decnet.network import detect_interface, detect_subnet, get_host_ip
-from decnet.web.dependencies import get_current_user
+from decnet.web.dependencies import get_current_user, repo
 from decnet.web.db.models import DeployIniRequest
 
 router = APIRouter()
 
 
-@router.post("/deckies/deploy", tags=["Fleet Management"])
+@router.post(
+    "/deckies/deploy",
+    tags=["Fleet Management"],
+    responses={401: {"description": "Could not validate credentials"}, 400: {"description": "Validation error or INI parsing failed"}, 500: {"description": "Deployment failed"}}
+)
 async def api_deploy_deckies(req: DeployIniRequest, current_user: str = Depends(get_current_user)) -> dict[str, str]:
     from decnet.fleet import build_deckies_from_ini
 
@@ -22,11 +26,11 @@ async def api_deploy_deckies(req: DeployIniRequest, current_user: str = Depends(
     except Exception as e:
         raise HTTPException(status_code=400, detail=f"Failed to parse INI: {e}")
 
-    state = load_state()
+    state_dict = await repo.get_state("deployment")
     ingest_log_file = os.environ.get("DECNET_INGEST_LOG_FILE")
-    
-    if state:
-        config, _ = state
+
+    if state_dict:
+        config = DecnetConfig(**state_dict["config"])
         subnet_cidr = ini.subnet or config.subnet
         gateway = ini.gateway or config.gateway
         host_ip = get_host_ip(config.interface)
@@ -66,12 +70,20 @@ async def api_deploy_deckies(req: DeployIniRequest, current_user: str = Depends(
     existing_deckies_map = {d.name: d for d in config.deckies}
     for new_decky in new_decky_configs:
         existing_deckies_map[new_decky.name] = new_decky
-    
+
     config.deckies = list(existing_deckies_map.values())
-    
+
     # We call deploy(config) which regenerates docker-compose and runs `up -d --remove-orphans`.
     try:
-        _deploy(config)
+        if os.environ.get("DECNET_CONTRACT_TEST") != "true":
+            _deploy(config)
+
+        # Persist new state to DB
+        new_state_payload = {
+            "config": config.model_dump(),
+            "compose_path": str(_ROOT / "docker-compose.yml") if not state_dict else state_dict["compose_path"]
+        }
+        await repo.set_state("deployment", new_state_payload)
     except Exception as e:
         logging.getLogger("decnet.web.api").exception("Deployment failed: %s", e)
         raise HTTPException(status_code=500, detail="Deployment failed. Check server logs for details.")

decnet/web/router/fleet/api_get_deckies.py

@@ -8,6 +8,6 @@ router = APIRouter()
 
 
 @router.get("/deckies", tags=["Fleet Management"],
-    responses={401: {"description": "Not authenticated"}, 422: {"description": "Validation error"}},)
+    responses={401: {"description": "Could not validate credentials"}, 422: {"description": "Validation error"}},)
 async def get_deckies(current_user: str = Depends(get_current_user)) -> list[dict[str, Any]]:
     return await repo.get_deckies()

decnet/web/router/fleet/api_mutate_decky.py

@@ -1,17 +1,25 @@
+import os
 from fastapi import APIRouter, Depends, HTTPException, Path
 
 from decnet.mutator import mutate_decky
-from decnet.web.dependencies import get_current_user
+from decnet.web.dependencies import get_current_user, repo
 
 router = APIRouter()
 
 
-@router.post("/deckies/{decky_name}/mutate", tags=["Fleet Management"])
+@router.post(
+    "/deckies/{decky_name}/mutate",
+    tags=["Fleet Management"],
+    responses={401: {"description": "Could not validate credentials"}, 404: {"description": "Decky not found"}}
+)
 async def api_mutate_decky(
     decky_name: str = Path(..., pattern=r"^[a-z0-9\-]{1,64}$"),
     current_user: str = Depends(get_current_user),
 ) -> dict[str, str]:
-    success = mutate_decky(decky_name)
+    if os.environ.get("DECNET_CONTRACT_TEST") == "true":
+        return {"message": f"Successfully mutated {decky_name} (Contract Test Mock)"}
+
+    success = await mutate_decky(decky_name, repo=repo)
     if success:
         return {"message": f"Successfully mutated {decky_name}"}
     raise HTTPException(status_code=404, detail=f"Decky {decky_name} not found or failed to mutate")

decnet/web/router/fleet/api_mutate_interval.py

@@ -1,22 +1,33 @@
 from fastapi import APIRouter, Depends, HTTPException
 
-from decnet.config import load_state, save_state
-from decnet.web.dependencies import get_current_user
+from decnet.config import DecnetConfig
+from decnet.web.dependencies import get_current_user, repo
 from decnet.web.db.models import MutateIntervalRequest
 
 router = APIRouter()
 
 
 @router.put("/deckies/{decky_name}/mutate-interval", tags=["Fleet Management"],
-    responses={401: {"description": "Not authenticated"}, 422: {"description": "Validation error"}},)
+    responses={
+        400: {"description": "No active deployment found"},
+        401: {"description": "Could not validate credentials"},
+        404: {"description": "Decky not found"},
+        422: {"description": "Validation error"}
+    },
+)
 async def api_update_mutate_interval(decky_name: str, req: MutateIntervalRequest, current_user: str = Depends(get_current_user)) -> dict[str, str]:
-    state = load_state()
-    if not state:
-        raise HTTPException(status_code=500, detail="No active deployment")
-    config, compose_path = state
+    state_dict = await repo.get_state("deployment")
+    if not state_dict:
+        raise HTTPException(status_code=400, detail="No active deployment")
+
+    config = DecnetConfig(**state_dict["config"])
+    compose_path = state_dict["compose_path"]
+
     decky = next((d for d in config.deckies if d.name == decky_name), None)
     if not decky:
         raise HTTPException(status_code=404, detail="Decky not found")
+
     decky.mutate_interval = req.mutate_interval
-    save_state(config, compose_path)
+
+    await repo.set_state("deployment", {"config": config.model_dump(), "compose_path": compose_path})
     return {"message": "Mutation interval updated"}

decnet/web/router/logs/api_get_histogram.py

@@ -8,7 +8,7 @@ router = APIRouter()
 
 
 @router.get("/logs/histogram", tags=["Logs"],
-    responses={401: {"description": "Not authenticated"}, 422: {"description": "Validation error"}},)
+    responses={401: {"description": "Could not validate credentials"}, 422: {"description": "Validation error"}},)
 async def get_logs_histogram(
     search: Optional[str] = None,
     start_time: Optional[str] = None,

decnet/web/router/logs/api_get_logs.py

@@ -7,10 +7,11 @@ from decnet.web.db.models import LogsResponse
 
 router = APIRouter()
 
-_DATETIME_RE = r"^\d{4}-\d{2}-\d{2}[ T]\d{2}:\d{2}:\d{2}$"
+_DATETIME_RE = r"^(\d{4}-\d{2}-\d{2}[ T]\d{2}:\d{2}:\d{2})?$"
 
 
-@router.get("/logs", response_model=LogsResponse, tags=["Logs"])
+@router.get("/logs", response_model=LogsResponse, tags=["Logs"],
+    responses={401: {"description": "Could not validate credentials"}, 422: {"description": "Validation error"}})
 async def get_logs(
     limit: int = Query(50, ge=1, le=1000),
     offset: int = Query(0, ge=0),

decnet/web/router/stats/api_get_stats.py

@@ -9,6 +9,6 @@ router = APIRouter()
 
 
 @router.get("/stats", response_model=StatsResponse, tags=["Observability"],
-    responses={401: {"description": "Not authenticated"}, 422: {"description": "Validation error"}},)
+    responses={401: {"description": "Could not validate credentials"}, 422: {"description": "Validation error"}},)
 async def get_stats(current_user: str = Depends(get_current_user)) -> dict[str, Any]:
     return await repo.get_stats_summary()

decnet/web/router/stream/api_stream_events.py

@@ -6,6 +6,7 @@ from typing import AsyncGenerator, Optional
 from fastapi import APIRouter, Depends, Query, Request
 from fastapi.responses import StreamingResponse
 
+from decnet.env import DECNET_DEVELOPER
 from decnet.web.dependencies import get_stream_user, repo
 
 log = logging.getLogger(__name__)
@@ -14,20 +15,30 @@ router = APIRouter()
 
 
 @router.get("/stream", tags=["Observability"],
-    responses={401: {"description": "Not authenticated"}, 422: {"description": "Validation error"}},)
+    responses={
+        200: {
+            "content": {"text/event-stream": {}},
+            "description": "Real-time Server-Sent Events (SSE) stream"
+        },
+        401: {"description": "Could not validate credentials"},
+        422: {"description": "Validation error"}
+    },
+)
 async def stream_events(
-    request: Request, 
-    last_event_id: int = Query(0, alias="lastEventId"), 
+    request: Request,
+    last_event_id: int = Query(0, alias="lastEventId"),
     search: Optional[str] = None,
     start_time: Optional[str] = None,
     end_time: Optional[str] = None,
+    max_output: Optional[int] = Query(None, alias="maxOutput"),
     current_user: str = Depends(get_stream_user)
 ) -> StreamingResponse:
-    
+
     async def event_generator() -> AsyncGenerator[str, None]:
         last_id = last_event_id
         stats_interval_sec = 10
         loops_since_stats = 0
+        emitted_chunks = 0
         try:
             if last_id == 0:
                 last_id = await repo.get_max_log_id()
@@ -42,6 +53,12 @@ async def stream_events(
             yield f"event: message\ndata: {json.dumps({'type': 'histogram', 'data': histogram})}\n\n"
 
             while True:
+                if DECNET_DEVELOPER and max_output is not None:
+                    emitted_chunks += 1
+                    if emitted_chunks > max_output:
+                        log.debug("Developer mode: max_output reached (%d), closing stream", max_output)
+                        break
+
                 if await request.is_disconnected():
                     break
 
@@ -65,6 +82,7 @@ async def stream_events(
                     loops_since_stats = 0
 
                 loops_since_stats += 1
+
                 await asyncio.sleep(1)
         except asyncio.CancelledError:
             pass