fix(auth): bulk-revoke sessions on password and role change

A stolen JWT used to survive a password reset for its full 24h. Now every
session-invalidating change moves the user's tokens_valid_from cutoff to
'now', so all of that user's prior tokens 401 on next use:

- self change-password, admin reset-password, role change all bump the
  cutoff (delete needs no bump: the row is gone, so the user lookup 401s).
- Cutoff is compared against the token's iat floored to whole seconds, so a
  re-login in the same second as the change isn't caught by its own
  revocation (the cost is a <=1s grey zone on same-second-old tokens).
- Per-user: changing one user never revokes another.
This commit is contained in:
2026-05-30 18:27:53 -04:00
parent c82897193e
commit 9fc489258b
4 changed files with 157 additions and 1 deletions

View File

@@ -195,8 +195,13 @@ async def _resolve_token(token: str) -> tuple[str, dict[str, Any]]:
if not jti:
raise _CREDENTIALS_EXCEPTION
# 2. Bulk cutoff: password/role change moves tokens_valid_from forward.
# JWT iat is whole-seconds, so floor the cutoff to whole seconds too —
# otherwise a re-login landing in the SAME second as the change gets an
# iat that truncates below a sub-second cutoff and is wrongly rejected.
# Cost: tokens issued earlier in that same second survive (≤1s), which is
# negligible against a 24h lifetime.
cutoff = user.get("tokens_valid_from")
if cutoff is not None and _epoch(payload.get("iat", 0)) < _epoch(cutoff):
if cutoff is not None and _epoch(payload.get("iat", 0)) < int(_epoch(cutoff)):
raise _CREDENTIALS_EXCEPTION
# 3. Single-token denylist (logout).
if await _is_revoked_cached(jti):