anti/DECNET
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Fix ips_to_range using XOR instead of subtraction for prefix length

Browse Source 
Subtraction underestimates the required prefix when IPs span a CIDR
boundary (e.g. .110–.119 gave /28 covering only .96–.111, leaving
deckies at .112+ unreachable from the host macvlan route).
XOR correctly finds the highest differing bit, yielding /27 (.96–.127).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
anti
2026-04-04 05:02:50 -03:00
parent 1b44b30329
commit 8276467dbb
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
decnet/network.py
View File

@@ -208,7 +208,7 @@ def ips_to_range(ips: list[str]) -> str:
""" """
addrs = [IPv4Address(ip) for ip in ips] addrs = [IPv4Address(ip) for ip in ips]
network = IPv4Network( network = IPv4Network(
(int(min(addrs)), 32 - (int(max(addrs)) - int(min(addrs))).bit_length()), (int(min(addrs)), 32 - (int(max(addrs)) ^ int(min(addrs))).bit_length()),
strict=False, strict=False,
) )
return str(network) return str(network)