anti/DECNET
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(frontend): ApiError interface, tempIdSuffix rename, NET_GRID constants, extract onPaletteDrop handlers

Browse Source 
ApiError: defined once in utils/api.ts, replaces 9 ad-hoc anonymous casts
across MazeNET, Inspector, DeckyFleet, SwarmHosts, Webhooks, PersonaGeneration,
ServiceConfigFields, CanaryTokens.

hex4 renamed to tempIdSuffix — the name now matches the comment that already
explained its purpose.

NET_GRID_{W,H,GAP,COLS} extracted from inline magic numbers to module-level
constants in MazeNET.tsx.

onPaletteDrop (130-line useCallback) split into three module-level handlers
(_dropNetwork, _dropArchetype, _dropService); the callback becomes a 10-line
router.
This commit is contained in:
anti
2026-04-30 22:14:20 -04:00
parent b754e9aa8b
commit 57fecb8071
9 changed files with 169 additions and 153 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
decnet_web/src/components/MazeNET/Inspector.tsx
View File

@@ -6,6 +6,7 @@ import {
import type { Net, MazeNode, Edge } from './types';
import { DEFAULT_SERVICES } from './data';
import ServiceConfigForm from '../ServiceConfigForm';
import type { ApiError } from '../../utils/api';
export type Selection =
| { type: 'net'; id: string }
@@ -173,7 +174,7 @@ const Inspector: React.FC<Props> = ({
try {
await onLiveRemoveService!(node.name, s);
} catch (err) {
const msg = (err as { response?: { data?: { detail?: string } } })?.response?.data?.detail
const msg = (err as ApiError)?.response?.data?.detail
?? 'Remove failed.';
setOpError(msg);
} finally {
@@ -314,7 +315,7 @@ const Inspector: React.FC<Props> = ({
try {
await onToggleGateway(node.id, next);
} catch (err) {
const msg = (err as { response?: { data?: { detail?: string } } })?.response?.data?.detail
const msg = (err as ApiError)?.response?.data?.detail
?? 'Gateway toggle failed.';
setOpError(msg);
} finally {
@@ -352,7 +353,7 @@ const Inspector: React.FC<Props> = ({
try {
await onLiveTarpitDisable!(node.name);
} catch (err) {
const msg = (err as { response?: { data?: { detail?: string } } })
const msg = (err as ApiError)
?.response?.data?.detail ?? 'Tarpit disable failed.';
setOpError(msg);
} finally {
@@ -406,7 +407,7 @@ const Inspector: React.FC<Props> = ({
await onLiveTarpitEnable!(node.name, ports, tarpitDelay);
setTarpitOpen(false);
} catch (err) {
const msg = (err as { response?: { data?: { detail?: string } } })
const msg = (err as ApiError)
?.response?.data?.detail ?? 'Tarpit enable failed.';
setOpError(msg);
} finally {