anti/DECNET
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(network): reload network before checking Containers on IPAM drift

Browse Source 
networks.list() returns bare objects — Containers is always empty
without a reload(). The active-endpoint guard from the prior commit
never fired because it was checking a stale empty dict.
This commit is contained in:
anti
2026-05-10 00:56:56 -04:00
parent 251181255b
commit 52a52eee78
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
decnet/network.py
View File

@@ -151,6 +151,13 @@ def _ensure_network(
options.update(extra_options) options.update(extra_options)
for net in client.networks.list(names=[MACVLAN_NETWORK_NAME]): for net in client.networks.list(names=[MACVLAN_NETWORK_NAME]):
# networks.list() doesn't populate Containers — reload to get the
# full inspect payload (including connected container IDs).
try:
net.reload()
except docker.errors.APIError:
pass
if net.attrs.get("Driver") == driver: if net.attrs.get("Driver") == driver:
# Same driver — but if the IPAM pool drifted (different subnet, # Same driver — but if the IPAM pool drifted (different subnet,
# gateway, or ip-range than this deploy asks for), reusing it # gateway, or ip-range than this deploy asks for), reusing it