perf: cache auth user-lookup and admin list_users
The per-request SELECT users WHERE uuid=? in require_role was the hidden tax behind every authed endpoint — it kept _execute at ~60% across the profile even after the page caches landed. Even /health (with its DB and Docker probes cached) was still 52% _execute from this one query. - dependencies.py: 10s TTL cache on get_user_by_uuid, well below JWT expiry. invalidate_user_cache(uuid) is called on password change, role change, and user delete. - api_get_config.py: 5s TTL cache on the admin branch's list_users() (previously fetched every /config call). Invalidated on user create/update/delete. - api_change_pass.py + api_manage_users.py: invalidation hooks on all user-mutating endpoints.
This commit is contained in:
@@ -4,7 +4,8 @@ from fastapi import APIRouter, Depends, HTTPException
|
||||
|
||||
from decnet.telemetry import traced as _traced
|
||||
from decnet.web.auth import ahash_password
|
||||
from decnet.web.dependencies import require_admin, repo
|
||||
from decnet.web.dependencies import require_admin, invalidate_user_cache, repo
|
||||
from decnet.web.router.config.api_get_config import invalidate_list_users_cache
|
||||
from decnet.web.db.models import (
|
||||
CreateUserRequest,
|
||||
UpdateUserRoleRequest,
|
||||
@@ -43,6 +44,7 @@ async def api_create_user(
|
||||
"role": req.role,
|
||||
"must_change_password": True, # nosec B105 — not a password
|
||||
})
|
||||
invalidate_list_users_cache()
|
||||
return UserResponse(
|
||||
uuid=user_uuid,
|
||||
username=req.username,
|
||||
@@ -71,6 +73,8 @@ async def api_delete_user(
|
||||
deleted = await repo.delete_user(user_uuid)
|
||||
if not deleted:
|
||||
raise HTTPException(status_code=404, detail="User not found")
|
||||
invalidate_user_cache(user_uuid)
|
||||
invalidate_list_users_cache()
|
||||
return {"message": "User deleted"}
|
||||
|
||||
|
||||
@@ -99,6 +103,8 @@ async def api_update_user_role(
|
||||
raise HTTPException(status_code=404, detail="User not found")
|
||||
|
||||
await repo.update_user_role(user_uuid, req.role)
|
||||
invalidate_user_cache(user_uuid)
|
||||
invalidate_list_users_cache()
|
||||
return {"message": "User role updated"}
|
||||
|
||||
|
||||
@@ -128,4 +134,6 @@ async def api_reset_user_password(
|
||||
await ahash_password(req.new_password),
|
||||
must_change_password=True,
|
||||
)
|
||||
invalidate_user_cache(user_uuid)
|
||||
invalidate_list_users_cache()
|
||||
return {"message": "Password reset successfully"}
|
||||
|
||||
Reference in New Issue
Block a user