fix(security): close LOW ASVS findings — env bypass, SSE/deployment authz, CN fail-close, password byte-limit, exception leaks, BUG-12..16
Auth/session (V2.1.7, V4.1.5, V4.1.6, V2.1.4/V2.1.5): - env secret validation no longer bypassed by attacker-injectable PYTEST* env; gated on explicit DECNET_TESTING=1 (set only in conftest). - must_change_password now enforced on the SSE header-JWT path, not just ticket mint. - GET /system/deployment-mode requires viewer auth (was leaking role + topology size). - CreateUser/ResetUser passwords min_length=12; passwords >72 bytes rejected explicitly instead of bcrypt silently truncating. Swarm ingestion (V9.1.3, BUG-16): - Log listener hard-rejects peers with unparseable/empty cert CN (fail closed, ingests nothing) instead of tagging 'unknown'. - Shutdown handlers no longer swallow real errors (narrowed to CancelledError). Info leakage (V7.1.2, V14.1.2): - Exception text sanitized on swarm-update, health, tarpit, realism, file-drop, blank-topology endpoints (raw tc/docker stderr, DB/Docker errors logged server-side, generic detail returned). pyproject license corrected to AGPL-3.0. Correctness (BUG-12..16): - BUG-12 atomic credential upsert (UNIQUE constraint + IntegrityError retry, consistent principal_key canonicalization). - BUG-13 rule-tail watermark uses >= with seen-id dedup (no same-second drop). - BUG-14 worker wake cleared before wait (no lost wake during tick). - BUG-15 intel gather tolerates an unexpected provider raise. - BUG-16 see above. Already-closed (verified, no change): V2.1.6, V5.1.3, V9.1.2. Accept-risk + documented: V2.1.8 cache window, V3.1.3 idle timeout. Tests added for every fix; unanimous adversarial review after two refute-fix rounds.
This commit is contained in:
@@ -80,6 +80,43 @@ async def test_sse_ticket_endpoint_mints_and_redeems(
|
||||
assert "uuid" in identity and identity["role"] in ("admin", "viewer")
|
||||
|
||||
|
||||
@pytest.mark.anyio
|
||||
async def test_sse_header_jwt_rejects_must_change_password(monkeypatch) -> None:
|
||||
"""V4.1.5: the header-JWT SSE branch must enforce must_change_password the
|
||||
same way require_role does. A user blocked from every REST endpoint must not
|
||||
be able to subscribe to live SSE streams with their existing token."""
|
||||
async def _fake_resolve(token: str):
|
||||
return "user-1", {"uuid": "user-1", "role": "viewer", "must_change_password": True}
|
||||
|
||||
monkeypatch.setattr(deps, "_resolve_token", _fake_resolve)
|
||||
|
||||
class _Req:
|
||||
headers = {"Authorization": "Bearer some.jwt.token"}
|
||||
|
||||
gate = deps.require_stream_role("viewer", "admin")
|
||||
with pytest.raises(HTTPException) as exc:
|
||||
await gate(_Req(), ticket=None) # type: ignore[arg-type]
|
||||
assert exc.value.status_code == 403
|
||||
assert "Password change required" in exc.value.detail
|
||||
|
||||
|
||||
@pytest.mark.anyio
|
||||
async def test_sse_header_jwt_allows_cleared_user(monkeypatch) -> None:
|
||||
"""Control: a user who has cleared must_change_password passes the header-JWT
|
||||
SSE gate (proves the new guard didn't break the happy path)."""
|
||||
async def _fake_resolve(token: str):
|
||||
return "user-1", {"uuid": "user-1", "role": "viewer", "must_change_password": False}
|
||||
|
||||
monkeypatch.setattr(deps, "_resolve_token", _fake_resolve)
|
||||
|
||||
class _Req:
|
||||
headers = {"Authorization": "Bearer some.jwt.token"}
|
||||
|
||||
gate = deps.require_stream_role("viewer", "admin")
|
||||
user = await gate(_Req(), ticket=None) # type: ignore[arg-type]
|
||||
assert user["uuid"] == "user-1"
|
||||
|
||||
|
||||
def test_raw_jwt_in_sse_query_rejected() -> None:
|
||||
"""V3.1.1: a raw JWT is not a valid opaque ticket — _redeem_sse_ticket rejects
|
||||
any token that wasn't minted by mint_sse_ticket (unknown key → 401)."""
|
||||
|
||||
Reference in New Issue
Block a user