fix(types): P3 — annotate transport in all template protocol servers; 0 errors in templates/
- asyncio.Protocol (TCP): _transport: asyncio.Transport | None = None + cast() in connection_made; assert guards in every method that directly accesses the field. Files: pop3, smtp, mqtt, postgres, mssql, mongodb, imap, ldap, redis, mysql, sip, vnc. - asyncio.DatagramProtocol (UDP): _transport: asyncio.DatagramTransport | None = None. Files: snmp, tftp, SIPUDPProtocol. - RDP: assert new_transport is not None after start_tls() to narrow Transport | None. - FTP (Twisted): assert self.transport is not None + targeted type: ignore for imprecise Twisted stubs (misc/override/arg-type/attr-defined), IReactorTCP cast for listenTCP. - conpot: proc.stdout is None guard before iteration. - Bonus fixes surfaced by annotation: - smtp: get_payload(decode=True) bytes narrowing (arg-type on sha256) - postgres: rename shadowed `msg` param to `err_msg` in _handle_startup - mongodb: base64.binascii.Error → import binascii; binascii.Error - imap: result: list[int] = [] (var-annotated)
This commit is contained in:
@@ -8,6 +8,7 @@ then responds with an error packet. Logs all requests as JSON.
|
||||
import asyncio
|
||||
import os
|
||||
import struct
|
||||
from typing import cast
|
||||
from syslog_bridge import syslog_line, write_syslog_file, forward_syslog
|
||||
|
||||
NODE_NAME = os.environ.get("NODE_NAME", "tftpserver")
|
||||
@@ -33,11 +34,13 @@ def _log(event_type: str, severity: int = 6, **kwargs) -> None:
|
||||
|
||||
|
||||
class TFTPProtocol(asyncio.DatagramProtocol):
|
||||
_transport: asyncio.DatagramTransport | None = None
|
||||
|
||||
def __init__(self):
|
||||
self._transport = None
|
||||
|
||||
def connection_made(self, transport):
|
||||
self._transport = transport
|
||||
def connection_made(self, transport: asyncio.BaseTransport) -> None:
|
||||
self._transport = cast(asyncio.DatagramTransport, transport)
|
||||
|
||||
def datagram_received(self, data: bytes, addr):
|
||||
if len(data) < 4:
|
||||
@@ -56,7 +59,8 @@ class TFTPProtocol(asyncio.DatagramProtocol):
|
||||
filename=filename,
|
||||
mode=mode,
|
||||
)
|
||||
self._transport.sendto(_error_pkt(2, "Access violation"), addr)
|
||||
if self._transport is not None:
|
||||
self._transport.sendto(_error_pkt(2, "Access violation"), addr)
|
||||
else:
|
||||
_log("unknown_opcode", src=addr[0], opcode=opcode, data=data[:32].hex())
|
||||
|
||||
|
||||
Reference in New Issue
Block a user