refactor(realism): move emailgen LLM/personas/prompt into shared library
Lift the format-agnostic pieces from decnet/orchestrator/emailgen/
into the new decnet/realism/ library so file-class content generation
(stage 3 of the realism migration) can reuse them. Email-specific
delivery (RFC 2822 EML, IMAP/POP3 spool, thread chains) stays in
orchestrator/.
Renames (history-preserving git mv):
emailgen/personas.py -> realism/personas.py
emailgen/prompt.py -> realism/prompts/email.py
emailgen/global_pool.py -> realism/personas_pool.py
emailgen/llm/ -> realism/llm/
Env-var clean break (pre-v1, no aliases):
DECNET_EMAILGEN_LLM -> DECNET_REALISM_LLM
DECNET_EMAILGEN_MODEL -> DECNET_REALISM_MODEL
DECNET_EMAILGEN_TIMEOUT -> DECNET_REALISM_TIMEOUT
DECNET_EMAILGEN_PERSONAS -> DECNET_REALISM_PERSONAS
DECNET_EMAILGEN_FAKE_OUTPUT -> DECNET_REALISM_FAKE_OUTPUT
Importers rewritten in: orchestrator/emailgen/scheduler.py,
orchestrator/drivers/email.py, web/router/{emailgen,topology}/
api_personas.py, cli/emailgen.py. Tests for moved modules relocated
to tests/realism/; tests for stay-put modules updated in place.
API URL `/api/v1/emailgen/personas` and CLI `decnet emailgen
import-personas` keep their public names until the service-collapse
commit (stage 5).
This commit is contained in:
@@ -7,7 +7,7 @@ import pytest
|
||||
from typer.testing import CliRunner
|
||||
|
||||
from decnet.cli import app
|
||||
from decnet.orchestrator.emailgen import global_pool
|
||||
from decnet.realism import personas_pool as global_pool
|
||||
|
||||
|
||||
@pytest.fixture(autouse=True)
|
||||
@@ -39,7 +39,7 @@ def test_import_personas_writes_canonical_file(tmp_path, monkeypatch):
|
||||
src = tmp_path / "src.json"
|
||||
src.write_text(json.dumps(_TWO))
|
||||
dest = tmp_path / "global_pool.json"
|
||||
monkeypatch.setenv("DECNET_EMAILGEN_PERSONAS", str(dest))
|
||||
monkeypatch.setenv("DECNET_REALISM_PERSONAS", str(dest))
|
||||
|
||||
result = CliRunner().invoke(
|
||||
app, ["emailgen", "import-personas", str(src)]
|
||||
@@ -55,7 +55,7 @@ def test_import_personas_explicit_output_overrides_env(tmp_path, monkeypatch):
|
||||
src.write_text(json.dumps(_TWO))
|
||||
env_dest = tmp_path / "env.json"
|
||||
explicit = tmp_path / "explicit.json"
|
||||
monkeypatch.setenv("DECNET_EMAILGEN_PERSONAS", str(env_dest))
|
||||
monkeypatch.setenv("DECNET_REALISM_PERSONAS", str(env_dest))
|
||||
|
||||
result = CliRunner().invoke(
|
||||
app,
|
||||
@@ -79,7 +79,7 @@ def test_import_personas_rejects_invalid_json(tmp_path):
|
||||
def test_import_personas_rejects_non_list(tmp_path, monkeypatch):
|
||||
src = tmp_path / "src.json"
|
||||
src.write_text(json.dumps({"not": "a list"}))
|
||||
monkeypatch.setenv("DECNET_EMAILGEN_PERSONAS", str(tmp_path / "out.json"))
|
||||
monkeypatch.setenv("DECNET_REALISM_PERSONAS", str(tmp_path / "out.json"))
|
||||
result = CliRunner().invoke(
|
||||
app, ["emailgen", "import-personas", str(src)]
|
||||
)
|
||||
@@ -92,7 +92,7 @@ def test_import_personas_rejects_all_invalid_entries(tmp_path, monkeypatch):
|
||||
src.write_text(json.dumps([
|
||||
{"name": "broken", "email": "no-at-symbol"},
|
||||
]))
|
||||
monkeypatch.setenv("DECNET_EMAILGEN_PERSONAS", str(tmp_path / "out.json"))
|
||||
monkeypatch.setenv("DECNET_REALISM_PERSONAS", str(tmp_path / "out.json"))
|
||||
result = CliRunner().invoke(
|
||||
app, ["emailgen", "import-personas", str(src)]
|
||||
)
|
||||
@@ -104,7 +104,7 @@ def test_import_personas_warns_on_single_persona(tmp_path, monkeypatch):
|
||||
src = tmp_path / "src.json"
|
||||
src.write_text(json.dumps(_TWO[:1]))
|
||||
dest = tmp_path / "out.json"
|
||||
monkeypatch.setenv("DECNET_EMAILGEN_PERSONAS", str(dest))
|
||||
monkeypatch.setenv("DECNET_REALISM_PERSONAS", str(dest))
|
||||
result = CliRunner().invoke(
|
||||
app, ["emailgen", "import-personas", str(src)]
|
||||
)
|
||||
@@ -117,7 +117,7 @@ def test_imported_personas_load_via_global_pool(tmp_path, monkeypatch):
|
||||
src = tmp_path / "src.json"
|
||||
src.write_text(json.dumps(_TWO))
|
||||
dest = tmp_path / "out.json"
|
||||
monkeypatch.setenv("DECNET_EMAILGEN_PERSONAS", str(dest))
|
||||
monkeypatch.setenv("DECNET_REALISM_PERSONAS", str(dest))
|
||||
|
||||
result = CliRunner().invoke(
|
||||
app, ["emailgen", "import-personas", str(src)]
|
||||
|
||||
Reference in New Issue
Block a user