fix(web): proxy follows DECNET_API_HOST instead of hardcoding 127.0.0.1
The dashboard's /api/* proxy hardcoded 127.0.0.1 as the target host. That works when the API binds to a wildcard or to loopback, but breaks the moment an operator binds the API to a specific address — e.g. a Tailscale IP for tailnet-only deploys: the API stops listening on loopback entirely and the proxy gets ECONNREFUSED on every request. The web command now reads DECNET_API_HOST and falls back to loopback only when the API is on a wildcard (0.0.0.0 / :: / unset). A new --api-host flag overrides at the CLI level.
This commit is contained in:
36
tests/cli/test_web_proxy_target.py
Normal file
36
tests/cli/test_web_proxy_target.py
Normal file
@@ -0,0 +1,36 @@
|
||||
"""The web dashboard proxy must follow DECNET_API_HOST.
|
||||
|
||||
Hardcoding 127.0.0.1 broke deploys where the operator binds the API to
|
||||
a specific tailnet/VPN address: the API drops loopback entirely and the
|
||||
proxy gets ECONNREFUSED. Wildcard binds still proxy via loopback because
|
||||
both processes share the host.
|
||||
"""
|
||||
from __future__ import annotations
|
||||
|
||||
from decnet.cli.web import _proxy_target
|
||||
|
||||
|
||||
def test_loopback_passthrough() -> None:
|
||||
assert _proxy_target("127.0.0.1") == "127.0.0.1"
|
||||
|
||||
|
||||
def test_wildcard_v4_falls_back_to_loopback() -> None:
|
||||
assert _proxy_target("0.0.0.0") == "127.0.0.1"
|
||||
|
||||
|
||||
def test_wildcard_v6_falls_back_to_loopback() -> None:
|
||||
assert _proxy_target("::") == "127.0.0.1"
|
||||
|
||||
|
||||
def test_empty_falls_back_to_loopback() -> None:
|
||||
assert _proxy_target("") == "127.0.0.1"
|
||||
|
||||
|
||||
def test_specific_address_is_followed() -> None:
|
||||
# The case that was broken: API bound only on tailnet IP, proxy
|
||||
# tried loopback and got ECONNREFUSED.
|
||||
assert _proxy_target("100.64.1.7") == "100.64.1.7"
|
||||
|
||||
|
||||
def test_hostname_is_followed() -> None:
|
||||
assert _proxy_target("decnet-master.tailnet.ts.net") == "decnet-master.tailnet.ts.net"
|
||||
Reference in New Issue
Block a user